Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Issue 2504133003: Add more gn documentation (Closed)

Created:
4 years, 1 month ago by brettw
Modified:
4 years, 1 month ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews, Dirk Pranke, tfarina, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add more gn documentation Adds new topics on labels, overall build flow, and ninja rule generation. Enhances toolchain documentation. Removes duplicate content from language.md (which I want to go away -- this should be moved into the builtin help). Committed: https://crrev.com/189c461d55de98bab1f85abcac8e54203a1b9633 Cr-Commit-Position: refs/heads/master@{#432766}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+704 lines, -336 lines) Patch
M tools/gn/command_help.cc View 6 chunks +12 lines, -0 lines 0 comments Download
M tools/gn/docs/language.md View 2 chunks +0 lines, -272 lines 0 comments Download
M tools/gn/docs/reference.md View 119 chunks +418 lines, -32 lines 0 comments Download
M tools/gn/function_set_default_toolchain.cc View 1 chunk +9 lines, -1 line 0 comments Download
M tools/gn/function_toolchain.cc View 2 chunks +75 lines, -25 lines 0 comments Download
M tools/gn/label.h View 1 chunk +2 lines, -0 lines 0 comments Download
M tools/gn/label.cc View 1 chunk +55 lines, -0 lines 0 comments Download
M tools/gn/ninja_build_writer.h View 1 chunk +2 lines, -0 lines 0 comments Download
M tools/gn/ninja_build_writer.cc View 3 chunks +51 lines, -6 lines 0 comments Download
M tools/gn/target.h View 1 chunk +2 lines, -0 lines 0 comments Download
M tools/gn/target.cc View 1 chunk +78 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
brettw
4 years, 1 month ago (2016-11-16 18:52:29 UTC) #2
Dirk Pranke
lgtm. Looks like someone likes using raw string literals :). More seriously, if we do ...
4 years, 1 month ago (2016-11-17 02:57:45 UTC) #7
brettw
The raw strings make this so much easier to write! I'm also going to delete ...
4 years, 1 month ago (2016-11-17 05:31:47 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2504133003/1
4 years, 1 month ago (2016-11-17 05:32:43 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-17 05:39:03 UTC) #11
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 05:41:10 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/189c461d55de98bab1f85abcac8e54203a1b9633
Cr-Commit-Position: refs/heads/master@{#432766}

Powered by Google App Engine
This is Rietveld 408576698