Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(227)

Issue 2504063002: Revert of Remove IPC::BrokerableAttachment. (Closed)

Created:
4 years, 1 month ago by horo
Modified:
4 years, 1 month ago
CC:
Aaron Boodman, abarth-chromium, chrome-apps-syd-reviews_chromium.org, chromium-reviews, darin (slow to review), darin-cc_chromium.org, jam, mac-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, erikchen
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Remove IPC::BrokerableAttachment. (patchset #1 id:120001 of https://codereview.chromium.org/2494943002/ ) Reason for revert: Caused crash in NewlibPackagedAppTest.SuccessfulLoad browser_tests. See http://crbug.com/665678#c1 BUG=665678 Original issue's description: > Remove IPC::BrokerableAttachment. > > With only ChannelMojo in use, the distinction between brokerable and > non-brokerable attachments no longer makes sense. This CL removes that > distinction by removing BrokerableAttachment and flattening the > hierarchy of attachment types. > > This also trims some POSIX-specific parts of IPC::MessageAttachmentSet. > > BUG=659448 > > Committed: https://crrev.com/f6e03ce56c4d2370b79d0c3dd4ceb89cf5528e56 > Cr-Commit-Position: refs/heads/master@{#432153} TBR=rockot@chromium.org,dcheng@chromium.org,mseaborn@chromium.org,raymes@chromium.org,erikchen@chromium.org,sammc@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=659448 Committed: https://crrev.com/cff1de9d81338681be3687697038553691b52c88 Cr-Commit-Position: refs/heads/master@{#432351}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+569 lines, -129 lines) Patch
M base/pickle.cc View 1 chunk +1 line, -0 lines 0 comments Download
M components/nacl/loader/nacl_ipc_adapter.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ipc/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
A ipc/brokerable_attachment.h View 1 chunk +54 lines, -0 lines 0 comments Download
A ipc/brokerable_attachment.cc View 1 chunk +34 lines, -0 lines 0 comments Download
M ipc/handle_attachment_win.h View 2 chunks +42 lines, -3 lines 0 comments Download
M ipc/handle_attachment_win.cc View 1 chunk +13 lines, -2 lines 0 comments Download
M ipc/handle_win.cc View 1 chunk +8 lines, -2 lines 0 comments Download
M ipc/ipc_channel_mojo.cc View 4 chunks +22 lines, -7 lines 0 comments Download
M ipc/ipc_channel_mojo_unittest.cc View 1 chunk +5 lines, -6 lines 0 comments Download
M ipc/ipc_channel_nacl.h View 2 chunks +6 lines, -3 lines 0 comments Download
M ipc/ipc_channel_nacl.cc View 4 chunks +16 lines, -25 lines 0 comments Download
M ipc/ipc_channel_reader.h View 2 chunks +3 lines, -2 lines 0 comments Download
M ipc/ipc_channel_reader.cc View 1 chunk +1 line, -1 line 0 comments Download
M ipc/ipc_channel_reader_unittest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M ipc/ipc_message.h View 2 chunks +5 lines, -0 lines 0 comments Download
M ipc/ipc_message.cc View 4 chunks +21 lines, -2 lines 0 comments Download
M ipc/ipc_message_attachment.h View 2 chunks +9 lines, -2 lines 0 comments Download
M ipc/ipc_message_attachment_set.h View 4 chunks +77 lines, -15 lines 0 comments Download
M ipc/ipc_message_attachment_set.cc View 8 chunks +116 lines, -19 lines 0 comments Download
M ipc/ipc_message_attachment_set_posix_unittest.cc View 5 chunks +60 lines, -20 lines 0 comments Download
M ipc/ipc_message_utils.h View 1 chunk +1 line, -0 lines 0 comments Download
M ipc/ipc_message_utils.cc View 1 chunk +1 line, -7 lines 0 comments Download
M ipc/ipc_mojo_handle_attachment.h View 1 chunk +5 lines, -0 lines 0 comments Download
M ipc/ipc_mojo_handle_attachment.cc View 1 chunk +8 lines, -1 line 0 comments Download
M ipc/ipc_mojo_message_helper.cc View 1 chunk +1 line, -1 line 0 comments Download
M ipc/ipc_platform_file_attachment_posix.h View 1 chunk +1 line, -1 line 0 comments Download
M ipc/ipc_platform_file_attachment_posix.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ipc/mach_port_attachment_mac.h View 2 chunks +31 lines, -3 lines 0 comments Download
M ipc/mach_port_attachment_mac.cc View 2 chunks +12 lines, -2 lines 0 comments Download
M ipc/mach_port_mac.cc View 1 chunk +8 lines, -2 lines 0 comments Download
M ppapi/proxy/nacl_message_scanner.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
horo
Created Revert of Remove IPC::BrokerableAttachment.
4 years, 1 month ago (2016-11-16 01:44:33 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2504063002/1
4 years, 1 month ago (2016-11-16 01:44:54 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-16 01:53:25 UTC) #5
commit-bot: I haz the power
4 years, 1 month ago (2016-11-16 01:57:17 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cff1de9d81338681be3687697038553691b52c88
Cr-Commit-Position: refs/heads/master@{#432351}

Powered by Google App Engine
This is Rietveld 408576698