Issue 25040006: Add a comment to a subtle use of OwnPtr::release()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 25040006: Add a comment to a subtle use of OwnPtr::release() (Closed)

Created:
7 years, 2 months ago by Steve Block

Modified:
7 years, 2 months ago

Reviewers:
dstockwell

CC:
blink-reviews, shans, rjwright, alancutter (OOO until 2018), Mike Lawther (Google), dstockwell, Timothy Loh, darktears, dino_apple.com, Eric Willigers

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Add a comment to a subtle use of OwnPtr::release() BUG=240653 R=dstockwell@chromium.org, dstockwell Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=158621

Patch Set 1 #

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -0 lines)			Patch
	M	Source/core/animation/css/CSSAnimations.cpp	View		1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/steveblock@chromium.org/25040006/1

7 years, 2 months ago (2013-09-30 21:48:27 UTC) #3

commit-bot: I haz the power

Retried try job too often on win_blink_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_blink_rel&number=7855

7 years, 2 months ago (2013-10-01 06:41:02 UTC) #4

Steve Block

7 years, 2 months ago (2013-10-01 10:39:46 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 manually as r158621 (presubmit successful).

Expand Messages | Collapse Messages