content/shell/android/shell_apk/src/org/chromium/content_shell_apk/ContentShellActivity.java - Issue 25040002: Enables fullscreen subtitle and media control from Blink

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/shell/android/shell_apk/src/org/chromium/content_shell_apk/ContentShellActivity.java

Issue 25040002: Enables fullscreen subtitle and media control from Blink (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@build_hack

Patch Set: Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/shell/android/java/src/org/chromium/content_shell/ShellManager.java ('K') | « content/shell/android/java/src/org/chromium/content_shell/ShellManager.java ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/shell/android/shell_apk/src/org/chromium/content_shell_apk/ContentShellActivity.java

diff --git a/content/shell/android/shell_apk/src/org/chromium/content_shell_apk/ContentShellActivity.java b/content/shell/android/shell_apk/src/org/chromium/content_shell_apk/ContentShellActivity.java

index a4e477fb1770788cad2a1f4b71ceb1f362c11493..5d917c8d664b824da35cec4474cb551e61900fc9 100644

--- a/content/shell/android/shell_apk/src/org/chromium/content_shell_apk/ContentShellActivity.java

+++ b/content/shell/android/shell_apk/src/org/chromium/content_shell_apk/ContentShellActivity.java

@@ -13,6 +13,7 @@ import android.os.Bundle;

import android.text.TextUtils;

import android.util.Log;

import android.view.KeyEvent;

+import android.view.View;

import android.widget.Toast;

import org.chromium.base.MemoryPressureListener;

@@ -131,7 +132,19 @@ public class ContentShellActivity extends Activity {

getActiveContentView().setContentViewClient(new ContentViewClient() {

@Override

public ContentVideoViewClient getContentVideoViewClient() {

- return new ActivityContentVideoViewClient(ContentShellActivity.this);

+ return new ActivityContentVideoViewClient(ContentShellActivity.this) {

Ted C 2013/09/30 15:54:36 Do you need to do something similar for the Chromi

+ @Override

+ public void onShowCustomView(View view) {

+ super.onShowCustomView(view);

+ mShellManager.setOverlayVideoMode(true);

+ }

+ @Override

+ public void onDestroyContentVideoView() {

+ super.onDestroyContentVideoView();

+ mShellManager.setOverlayVideoMode(false);

+ }

+ };

}

});

}