content/public/android/java/src/org/chromium/content/browser/ContentVideoViewClient.java - Issue 25040002: Enables fullscreen subtitle and media control from Blink

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/android/java/src/org/chromium/content/browser/ContentVideoViewClient.java

Issue 25040002: Enables fullscreen subtitle and media control from Blink (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@build_hack

Patch Set: Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/public/android/java/src/org/chromium/content/browser/ContentVideoView.java ('K') | « content/public/android/java/src/org/chromium/content/browser/ContentVideoView.java ('k') | content/public/android/java/src/org/chromium/content/browser/ContentViewRenderView.java » ('j') | content/shell/android/java/src/org/chromium/content_shell/ShellManager.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/public/android/java/src/org/chromium/content/browser/ContentVideoViewClient.java

diff --git a/content/public/android/java/src/org/chromium/content/browser/ContentVideoViewClient.java b/content/public/android/java/src/org/chromium/content/browser/ContentVideoViewClient.java

index 985f993f25f169779079dfc5a387259cd0ec1bd7..7991ff31c8d1f2a3eaf48682c28337f2bab4e37b 100644

--- a/content/public/android/java/src/org/chromium/content/browser/ContentVideoViewClient.java

+++ b/content/public/android/java/src/org/chromium/content/browser/ContentVideoViewClient.java

@@ -34,10 +34,4 @@ public interface ContentVideoViewClient {

* If null is returned, the default video loading view is used.

public View getVideoLoadingProgressView();

- /**

- * Allows the embedder to replace the default playback controls by returning a custom

- * implementation. If null is returned, the default controls are used.

- */

- public ContentVideoViewControls createControls();

}