Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(445)

Issue 2503983002: MD History: Focus item checkbox when selecting/deselecting on click (Closed)

Created:
4 years, 1 month ago by tsergeant
Modified:
4 years, 1 month ago
Reviewers:
calamity
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, Patrick Dubroy, michaelpg+watch-md-ui_chromium.org, dbeam+watch-history_chromium.org, pam+watch_chromium.org, arv+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD History: Focus item checkbox when selecting/deselecting on click Previously, tapping an item would select or deselect item, and would move focus to that item without changing which button or link was focused. This could mean that the checkbox could select while the menu button was focused. This CL ensures that the menu button is always focused after tapping an item. BUG=620036 Committed: https://crrev.com/1b514db4465c955d81bcd26bae62e2062909fa6a Cr-Commit-Position: refs/heads/master@{#432794}

Patch Set 1 #

Patch Set 2 : Add a test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -44 lines) Patch
M chrome/browser/resources/md_history/app.crisper.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/md_history/history_item.js View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/test/data/webui/md_history/history_item_test.js View 1 2 chunks +55 lines, -43 lines 0 comments Download

Messages

Total messages: 23 (14 generated)
tsergeant
4 years, 1 month ago (2016-11-16 03:22:43 UTC) #7
calamity
lgtm
4 years, 1 month ago (2016-11-17 02:25:38 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2503983002/20001
4 years, 1 month ago (2016-11-17 03:54:04 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: closure_compilation on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/closure_compilation/builds/4303)
4 years, 1 month ago (2016-11-17 04:23:10 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2503983002/20001
4 years, 1 month ago (2016-11-17 04:40:08 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/318944)
4 years, 1 month ago (2016-11-17 06:01:10 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2503983002/20001
4 years, 1 month ago (2016-11-17 06:07:19 UTC) #19
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-17 07:04:06 UTC) #21
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 07:08:24 UTC) #23
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/1b514db4465c955d81bcd26bae62e2062909fa6a
Cr-Commit-Position: refs/heads/master@{#432794}

Powered by Google App Engine
This is Rietveld 408576698