Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(357)

Issue 2503933002: [Android] spellcheck: add availability UMA. (Closed)

Created:
4 years, 1 month ago by timvolodine
Modified:
4 years, 1 month ago
CC:
chromium-reviews, rlp+watch_chromium.org, rouslan+spell_chromium.org, asvitkine+watch_chromium.org, agrieve+watch_chromium.org, groby+spellwatch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android] spellcheck: add availability UMA. Add spellchecking service availability measurement on Android. This measures whether the system spellchecking service was available at the start of each new spellchecking session during the editing of textual input html elements. Note that the service can be unavailable because the user has disabled it in the Android settings. BUG=660074, 629609 Committed: https://crrev.com/d88cfcd00c078a5e54266f1f5f3eda07582f367f Cr-Commit-Position: refs/heads/master@{#432975}

Patch Set 1 #

Patch Set 2 : make sure to only record UMA at the start of session #

Patch Set 3 : tweak histogram description #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -2 lines) Patch
M components/spellcheck/browser/spellchecker_session_bridge_android.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M components/spellcheck/browser/spellchecker_session_bridge_android.cc View 1 5 chunks +22 lines, -2 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 2 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 25 (17 generated)
timvolodine
4 years, 1 month ago (2016-11-15 19:29:01 UTC) #4
timvolodine
+isherman@ : for histograms.xml
4 years, 1 month ago (2016-11-15 19:29:34 UTC) #6
Ilya Sherman
lgtm
4 years, 1 month ago (2016-11-15 22:30:17 UTC) #9
Tobias Sargeant
On 2016/11/15 22:30:17, Ilya Sherman wrote: > lgtm RS LGTM
4 years, 1 month ago (2016-11-17 15:08:03 UTC) #10
timvolodine
On 2016/11/17 15:08:03, Tobias Sargeant wrote: > On 2016/11/15 22:30:17, Ilya Sherman wrote: > > ...
4 years, 1 month ago (2016-11-17 17:17:57 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2503933002/40001
4 years, 1 month ago (2016-11-17 20:14:19 UTC) #21
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 1 month ago (2016-11-17 21:46:34 UTC) #23
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 21:51:45 UTC) #25
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/d88cfcd00c078a5e54266f1f5f3eda07582f367f
Cr-Commit-Position: refs/heads/master@{#432975}

Powered by Google App Engine
This is Rietveld 408576698