Demonstrate external-window-mode in mus-demo

services/ui/ws/window_tree_unittest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "services/ui/ws/window_tree.h"
 
 #include <stdint.h>
 
 #include <string>
 #include <vector>
@@ skipping 1339 matching lines @@
 using WindowTreeShutdownTest = testing::Test;
 
 // Makes sure WindowTreeClient doesn't get any messages during shutdown.
 TEST_F(WindowTreeShutdownTest, DontSendMessagesDuringShutdown) {
   std::unique_ptr<TestWindowTreeClient> client;
   {
     // Create a tree with one window.
     WindowServerTestHelper ws_test_helper;
     WindowServer* window_server = ws_test_helper.window_server();
     TestPlatformScreen platform_screen;
-    platform_screen.Init(window_server->display_manager());
+    platform_screen.Init(window_server->display_manager(), false);

[tonikitoo, 2016/11/22 03:07:39]

for good code reading purposes, a named variable for this boolean or an enum
would be nice.

But it would require replication in varios places, so maybe you added the
boolean literal on purpose.

[Tom (Use chromium acct), 2016/11/22 19:19:48]

I've added the enum and also a default argument so that the various callsites
don't need to change

     window_server->user_id_tracker()->AddUserId(kTestUserId1);
     platform_screen.AddDisplay();
 
     AddWindowManager(window_server, kTestUserId1);
     window_server->user_id_tracker()->SetActiveUserId(kTestUserId1);
     TestWindowTreeBinding* test_binding =
         ws_test_helper.window_server_delegate()->last_binding();
     ASSERT_TRUE(test_binding);
     WindowTree* tree = test_binding->tree();
     const ClientWindowId window_id = BuildClientWindowId(tree, 2);
     ASSERT_TRUE(tree->NewWindow(window_id, ServerWindow::Properties()));
 
     // Release the client so that it survices shutdown.
     client = test_binding->ReleaseClient();
     client->tracker()->changes()->clear();
   }
 
   // Client should not have got any messages after shutdown.
   EXPECT_TRUE(client->tracker()->changes()->empty());
 }
 
 }  // namespace test
 }  // namespace ws
 }  // namespace ui