document.documentElement.scrollTop/Left is zero

Source/core/dom/Element.cpp

 /*
  * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
  *           (C) 1999 Antti Koivisto (koivisto@kde.org)
  *           (C) 2001 Peter Kelly (pmk@post.com)
  *           (C) 2001 Dirk Mueller (mueller@kde.org)
  *           (C) 2007 David Smith (catfish.man@gmail.com)
  * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2012, 2013 Apple Inc. All rights reserved.
  *           (C) 2007 Eric Seidel (eric@webkit.org)
  *
  * This library is free software; you can redistribute it and/or
@@ skipping 667 matching lines @@
     }
 
     if (RenderBox* renderer = renderBox())
         return adjustLayoutUnitForAbsoluteZoom(renderer->pixelSnappedClientHeight(), renderer).round();
     return 0;
 }
 
 int Element::scrollLeft()
 {
     document().updateLayoutIgnorePendingStylesheets();
+
+    bool inQuirksMode = document().inQuirksMode();

[Julien - ping for review, 2013/09/30 23:39:57]

For consistency, this should be moved inside the branch and the variable removed
like the other method.

[tonikitoo_, 2013/10/01 14:42:17]

Ok

+    if (document().documentElement() == this) {
+        if (inQuirksMode)
+            return 0;
+
+        if (FrameView* view = document().view()) {
+            if (RenderView* renderView = document().renderView())
+                return adjustForAbsoluteZoom(view->scrollX(), renderView);

[Julien - ping for review, 2013/09/30 23:39:57]

It would be nice to have some zoom testing too.

[tonikitoo_, 2013/10/01 14:42:17]

Do you think the test this patch edits in
LayoutTests/fast/css/zoom-body-scroll.html is enough?

[Julien - ping for review, 2013/10/01 15:19:51]

I missed this test which exercise this code, my bad. By the way, it is missing
an expected result so you won't be able to land this change as-is.

[tonikitoo_, 2013/10/01 16:49:19]

In fact, it changes the test fine. The expected result is kept.

+        }
+    }
+
     if (RenderBox* rend = renderBox())
         return adjustForAbsoluteZoom(rend->scrollLeft(), rend);
     return 0;
 }
 
 int Element::scrollTop()
 {
     document().updateLayoutIgnorePendingStylesheets();
+
+    if (document().documentElement() == this) {
+        if (document().inQuirksMode())
+            return 0;
+
+        if (FrameView* view = document().view()) {
+            if (RenderView* renderView = document().renderView())
+                return adjustForAbsoluteZoom(view->scrollY(), renderView);
+        }
+    }
+
     if (RenderBox* rend = renderBox())
         return adjustForAbsoluteZoom(rend->scrollTop(), rend);
     return 0;
 }
 
 void Element::setScrollLeft(int newLeft)
 {
     document().updateLayoutIgnorePendingStylesheets();
     if (RenderBox* rend = renderBox())
         rend->setScrollLeft(static_cast<int>(newLeft * rend->style()->effectiveZoom()));
@@ skipping 2936 matching lines @@
     return 0;
 }
 
 Attribute* UniqueElementData::attributeItem(unsigned index)
 {
     ASSERT_WITH_SECURITY_IMPLICATION(index < length());
     return &m_attributeVector.at(index);
 }
 
 } // namespace WebCore