Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(449)

Unified Diff: ui/gfx/render_text_unittest.cc

Issue 25039002: Always aligns text at vertically center (Textfield, Label). (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/gfx/render_text_unittest.cc
diff --git a/ui/gfx/render_text_unittest.cc b/ui/gfx/render_text_unittest.cc
index 75e985e01a8dc48870f31bb66397007e14adc145..350df9178e21629a6c5f75b28290e9d088f53b21 100644
--- a/ui/gfx/render_text_unittest.cc
+++ b/ui/gfx/render_text_unittest.cc
@@ -5,6 +5,7 @@
#include "ui/gfx/render_text.h"
#include <algorithm>
+#include <limits>
#include "base/format_macros.h"
#include "base/memory/scoped_ptr.h"
@@ -1139,6 +1140,8 @@ TEST_F(RenderTextTest, StringSizeEmptyString) {
const FontList font_list("Arial,Symbol, 16px");
scoped_ptr<RenderText> render_text(RenderText::CreateInstance());
render_text->SetFontList(font_list);
+ render_text->SetDisplayRect(Rect(0, 0, std::numeric_limits<int>::max(),
+ font_list.GetHeight()));
// The empty string respects FontList metrics for non-zero height
// and baseline.
@@ -1180,7 +1183,9 @@ TEST_F(RenderTextTest, StringSizeRespectsFontListMetrics) {
// Check |smaller_font_text| is rendered with the smaller font.
scoped_ptr<RenderText> render_text(RenderText::CreateInstance());
render_text->SetText(UTF8ToUTF16(smaller_font_text));
- render_text->SetFont(smaller_font);
+ render_text->SetFontList(FontList(smaller_font));
+ render_text->SetDisplayRect(Rect(0, 0, std::numeric_limits<int>::max(),
+ render_text->font_list().GetHeight()));
EXPECT_EQ(smaller_font.GetHeight(), render_text->GetStringSize().height());
EXPECT_EQ(smaller_font.GetBaseline(), render_text->GetBaseline());
@@ -1192,6 +1197,8 @@ TEST_F(RenderTextTest, StringSizeRespectsFontListMetrics) {
fonts.push_back(larger_font);
const FontList font_list(fonts);
render_text->SetFontList(font_list);
+ render_text->SetDisplayRect(Rect(0, 0, std::numeric_limits<int>::max(),
+ render_text->font_list().GetHeight()));
EXPECT_LT(smaller_font.GetHeight(), render_text->GetStringSize().height());
EXPECT_LT(smaller_font.GetBaseline(), render_text->GetBaseline());
EXPECT_EQ(font_list.GetHeight(), render_text->GetStringSize().height());
@@ -1321,17 +1328,6 @@ TEST_F(RenderTextTest, GetTextOffset) {
offset = render_text->GetLineOffset(0);
EXPECT_EQ(kEnlargement, offset.x());
- // Check explicitly setting the vertical alignment.
- render_text->SetVerticalAlignment(ALIGN_TOP);
- offset = render_text->GetLineOffset(0);
- EXPECT_EQ(0, offset.y());
- render_text->SetVerticalAlignment(ALIGN_VCENTER);
- offset = render_text->GetLineOffset(0);
- EXPECT_EQ(kEnlargement / 2, offset.y());
- render_text->SetVerticalAlignment(ALIGN_BOTTOM);
- offset = render_text->GetLineOffset(0);
- EXPECT_EQ(kEnlargement, offset.y());
-
SetRTL(was_rtl);
}

Powered by Google App Engine
This is Rietveld 408576698