MD Extensions: Replace toolbar/search field with cr-toolbar

MD Extensions: Replace toolbar/search field with cr-toolbar

cr-toolbar is a shared custom element which implements the full toolbar
that is used by Material WebUI pages.

BUG=665700
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/ceea98f08d159ea989123a2908e949fc3fd49b04
Cr-Commit-Position: refs/heads/master@{#435507}

[tsergeant, 2016-11-16 03:24:50]

Description was changed from

==========
MD Extensions: Replace toolbar/search field with cr-toolbar

cr-toolbar is a shared custom element which implements the full toolbar
that is used by Material WebUI pages.

BUG=529395
==========

to

==========
MD Extensions: Replace toolbar/search field with cr-toolbar

cr-toolbar is a shared custom element which implements the full toolbar
that is used by Material WebUI pages.

BUG=529395
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[tsergeant, 2016-11-16 03:53:01]

Description was changed from

==========
MD Extensions: Replace toolbar/search field with cr-toolbar

cr-toolbar is a shared custom element which implements the full toolbar
that is used by Material WebUI pages.

BUG=529395
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Extensions: Replace toolbar/search field with cr-toolbar

cr-toolbar is a shared custom element which implements the full toolbar
that is used by Material WebUI pages.

BUG=665700
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[tsergeant, 2016-11-29 04:20:47]

Patchset #2 (id:20001) has been deleted

[tsergeant, 2016-11-29 04:23:05]

tsergeant@chromium.org changed reviewers:
+ rdevlin.cronin@chromium.org

[tsergeant, 2016-11-29 04:23:05]

Hi Devlin, can you please take a look?

There are some screenshots on the bug. Wherever possible, I've tried to be
consistent with existing material webui pages. Thanks!

https://codereview.chromium.org/2503893003/diff/60001/chrome/browser/resource...
File chrome/browser/resources/md_extensions/manager.html (right):

https://codereview.chromium.org/2503893003/diff/60001/chrome/browser/resource...
chrome/browser/resources/md_extensions/manager.html:54: search field aligns with
History. */
With this CL, the search field is centered relative to the extension cards.
However, because of the extra 30px padding left of the cards, the search field
ends up being positioned slightly different to the History page.

I'll come through in a follow-up and try and remove the 30px margin so that the
two pages are consistent. This will probably involve making all of the subpages
centered within the content area, as shown by the mocks.

[Devlin, 2016-11-29 22:47:28]

extensions lgtm

[tsergeant, 2016-11-29 23:25:35]

tsergeant@chromium.org changed reviewers:
+ dpapad@chromium.org

[tsergeant, 2016-11-29 23:25:36]

+dpapad@ for the rest of c/b/resources and cr_elements

[dpapad, 2016-11-29 23:35:00]

https://codereview.chromium.org/2503893003/diff/60001/chrome/app/generated_re...
File chrome/app/generated_resources.grd (right):

https://codereview.chromium.org/2503893003/diff/60001/chrome/app/generated_re...
chrome/app/generated_resources.grd:4606: +          Clear search
We have a copy of that string for downloads, history and now extensions.
Settings is re-using the downloads one, see
https://cs.chromium.org/chromium/src/chrome/browser/ui/webui/settings/md_sett...
(and TODO). Can you simply re-use one of the existing ones for now?

[tsergeant, 2016-11-30 00:40:30]

https://codereview.chromium.org/2503893003/diff/60001/chrome/app/generated_re...
File chrome/app/generated_resources.grd (right):

https://codereview.chromium.org/2503893003/diff/60001/chrome/app/generated_re...
chrome/app/generated_resources.grd:4606: +          Clear search
On 2016/11/29 23:34:59, dpapad wrote:
> We have a copy of that string for downloads, history and now extensions.
> Settings is re-using the downloads one, see
>
https://cs.chromium.org/chromium/src/chrome/browser/ui/webui/settings/md_sett...
> (and TODO). Can you simply re-use one of the existing ones for now?

Done. I've used the string from downloads and added a TODO here too.

[dpapad, 2016-11-30 20:08:45]

LGTM

[tsergeant, 2016-11-30 21:52:49]

The CQ bit was checked by tsergeant@chromium.org

[tsergeant, 2016-11-30 21:52:49]

The patchset sent to the CQ was uploaded after l-g-t-m from
rdevlin.cronin@chromium.org
Link to the patchset: https://codereview.chromium.org/2503893003/#ps80001
(title: "Re-use clear search string.")

[commit-bot: I haz the power, 2016-11-30 21:53:31]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-30 23:52:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-30 23:52:07]

Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[tsergeant, 2016-12-01 00:15:23]

The CQ bit was checked by tsergeant@chromium.org

[commit-bot: I haz the power, 2016-12-01 00:17:13]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-01 00:57:34]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1480551323615010,
"parent_rev": "59b10afd29baf216b4fc4d3d75c46899fde8ebe6", "commit_rev":
"51c6abf55738fdf25efcc01f3e8ef7131b5d92dc"}

[commit-bot: I haz the power, 2016-12-01 00:58:02]

Committed patchset #4 (id:80001)

[commit-bot: I haz the power, 2016-12-01 01:01:06]

Description was changed from

==========
MD Extensions: Replace toolbar/search field with cr-toolbar

cr-toolbar is a shared custom element which implements the full toolbar
that is used by Material WebUI pages.

BUG=665700
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Extensions: Replace toolbar/search field with cr-toolbar

cr-toolbar is a shared custom element which implements the full toolbar
that is used by Material WebUI pages.

BUG=665700
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/ceea98f08d159ea989123a2908e949fc3fd49b04
Cr-Commit-Position: refs/heads/master@{#435507}
==========

[commit-bot: I haz the power, 2016-12-01 01:01:08]

Patchset 4 (id:??) landed as
https://crrev.com/ceea98f08d159ea989123a2908e949fc3fd49b04
Cr-Commit-Position: refs/heads/master@{#435507}