Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 2503883003: Revert of Create a subset of skia support for paths only (Closed)

Created:
4 years, 1 month ago by dsinclair
Modified:
4 years, 1 month ago
Reviewers:
caryclark, dsinclair1
CC:
pdfium-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Revert of Create a subset of skia support for paths only (patchset #10 id:180001 of https://codereview.chromium.org/2491693002/ ) Reason for revert: Breaking the chrome roll. https://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_compile_dbg_ng/builds/306015/steps/generate_build_files%20%28with%20patch%29/logs/stdio Original issue's description: > Create a subset of skia support for paths only > > This is a continuation of https://codereview.chromium.org/2346483006/ > > This removes the need for agg, without providing > full Skia support. > > It doesn't work yet, but it does compile and run > for simple PDFs. > > R=dsinclair@google.com > > Committed: https://pdfium.googlesource.com/pdfium/+/5d223298b26c9b2b6284cba9a51521d3873b6e58 TBR=dsinclair@google.com,caryclark@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://pdfium.googlesource.com/pdfium/+/f16f6b8b52277348f5d571b7641bb0bbd5239589

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -1245 lines) Patch
M BUILD.gn View 3 chunks +2 lines, -6 lines 0 comments Download
M README.md View 1 chunk +0 lines, -1 line 0 comments Download
M build_overrides/pdfium.gni View 1 chunk +1 line, -4 lines 0 comments Download
M core/fpdfapi/render/fpdf_render_image.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M core/fxge/apple/fx_quartz_device.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fxge/ge/cfx_renderdevice.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fxge/skia/fx_skia_device.h View 5 chunks +1 line, -16 lines 0 comments Download
M core/fxge/skia/fx_skia_device.cpp View 42 chunks +21 lines, -1205 lines 0 comments Download
M core/fxge/skia/fx_skia_device_unittest.cpp View 2 chunks +0 lines, -2 lines 0 comments Download
M pdfium.gni View 1 chunk +1 line, -4 lines 0 comments Download
M samples/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M third_party/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
dsinclair
Created Revert of Create a subset of skia support for paths only
4 years, 1 month ago (2016-11-15 15:44:17 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2503883003/1
4 years, 1 month ago (2016-11-15 15:44:23 UTC) #3
commit-bot: I haz the power
4 years, 1 month ago (2016-11-15 15:44:30 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/f16f6b8b52277348f5d571b7641bb0bbd523...

Powered by Google App Engine
This is Rietveld 408576698