Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Issue 2503863002: [turbofan] Fix deopt check for storing into constant field. (Closed)

Created:
4 years, 1 month ago by Jarin
Modified:
4 years, 1 month ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Fix deopt check for storing into constant field. BUG=chromium:626986 Committed: https://crrev.com/1900760e8fb2bb8682d44ab3a58f8196230598da Cr-Commit-Position: refs/heads/master@{#40990}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -3 lines) Patch
M src/compiler/js-native-context-specialization.cc View 1 chunk +4 lines, -3 lines 0 comments Download
A test/mjsunit/compiler/regress-626986.js View 1 chunk +23 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
Jarin
Could you take a look, please?
4 years, 1 month ago (2016-11-15 13:06:00 UTC) #4
Benedikt Meurer
LGTM, thanks.
4 years, 1 month ago (2016-11-15 13:07:08 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2503863002/1
4 years, 1 month ago (2016-11-15 13:07:29 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-15 13:16:25 UTC) #9
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:33:57 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1900760e8fb2bb8682d44ab3a58f8196230598da
Cr-Commit-Position: refs/heads/master@{#40990}

Powered by Google App Engine
This is Rietveld 408576698