Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1062)

Unified Diff: components/offline_pages/offline_page_model.h

Issue 2503853004: Support getting offline pages also by original URL (Closed)
Patch Set: Rebase Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/offline_pages/offline_page_model.h
diff --git a/components/offline_pages/offline_page_model.h b/components/offline_pages/offline_page_model.h
index 272f6dc9c0cfe2744853758c7dca29c5b62b6a4c..55c9755bdb0c3a60ac42b89ff2a5446e003274ba 100644
--- a/components/offline_pages/offline_page_model.h
+++ b/components/offline_pages/offline_page_model.h
@@ -160,9 +160,13 @@ class OfflinePageModel : public base::SupportsUserData {
int64_t offline_id,
const SingleOfflinePageItemCallback& callback) = 0;
- // Returns the offline pages that are stored under |online_url|.
- virtual void GetPagesByOnlineURL(
- const GURL& online_url,
+ // Returns the offline pages that are associated with |url|. If
+ // |search_by_final_url_only| is false, do the match using last committed
+ // URLs. Otherwise, either original URLs or last committed URLs coule be used
+ // for the match.
+ virtual void GetPagesByURL(
+ const GURL& url,
+ bool search_by_final_url_only,
fgorski 2016/11/16 23:43:46 enum here would be good too.
jianli 2016/11/17 01:12:14 Done.
const MultipleOfflinePageItemCallback& callback) = 0;
// Marks pages with |offline_ids| as expired and deletes the associated

Powered by Google App Engine
This is Rietveld 408576698