components/offline_pages/stub_offline_page_model.h - Issue 2503853004: Support getting offline pages also by original URL

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/offline_pages/stub_offline_page_model.h

Issue 2503853004: Support getting offline pages also by original URL (Closed)

Patch Set: Make NTP redirect work per comment Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/offline_pages/stub_offline_page_model.h

diff --git a/components/offline_pages/stub_offline_page_model.h b/components/offline_pages/stub_offline_page_model.h

index aeed349dd1ba2462cc389ffd710ac247ca2f5c24..a1031fa3e18578483f11f477fcfe87f8a1835864 100644

--- a/components/offline_pages/stub_offline_page_model.h

+++ b/components/offline_pages/stub_offline_page_model.h

@@ -54,8 +54,9 @@ class StubOfflinePageModel : public OfflinePageModel, public KeyedService {

void GetPageByOfflineId(

int64_t offline_id,

const SingleOfflinePageItemCallback& callback) override;

- void GetPagesByOnlineURL(

- const GURL& online_url,

+ void GetPagesByURL(

+ const GURL& url,

+ URLSearchMode url_search_mode,

const MultipleOfflinePageItemCallback& callback) override;

void ExpirePages(const std::vector<int64_t>& offline_ids,

const base::Time& expiration_time,