Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7546)

Unified Diff: chrome/browser/android/offline_pages/offline_page_tab_helper.cc

Issue 2503853004: Support getting offline pages also by original URL (Closed)
Patch Set: Make NTP redirect work per comment Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/offline_pages/offline_page_tab_helper.cc
diff --git a/chrome/browser/android/offline_pages/offline_page_tab_helper.cc b/chrome/browser/android/offline_pages/offline_page_tab_helper.cc
index 9a938dc4dbbb3bca38623d529cabc82dd30a320c..c287db626392ca7e524abc8eed4c49b0e6987a7b 100644
--- a/chrome/browser/android/offline_pages/offline_page_tab_helper.cc
+++ b/chrome/browser/android/offline_pages/offline_page_tab_helper.cc
@@ -131,15 +131,16 @@ void OfflinePageTabHelper::DidFinishNavigation(
return;
}
- OfflinePageUtils::SelectPageForOnlineURL(
+ OfflinePageUtils::SelectPageForURL(
web_contents()->GetBrowserContext(),
navigated_url,
+ OfflinePageModel::URLSearchMode::SEARCH_BY_ALL_URLS,
tab_id,
- base::Bind(&OfflinePageTabHelper::SelectPageForOnlineURLDone,
+ base::Bind(&OfflinePageTabHelper::SelectPageForURLDone,
weak_ptr_factory_.GetWeakPtr()));
}
-void OfflinePageTabHelper::SelectPageForOnlineURLDone(
+void OfflinePageTabHelper::SelectPageForURLDone(
const OfflinePageItem* offline_page) {
// Bails out if no offline page is found.
if (!offline_page) {

Powered by Google App Engine
This is Rietveld 408576698