Support getting offline pages also by original URL

components/offline_pages/offline_page_model_impl.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/offline_pages/offline_page_model_impl.h"
 
 #include <algorithm>
 #include <limits>
 
 #include "base/bind.h"
@@ skipping 590 matching lines @@
         }
       },
       callback);
 
   RunWhenLoaded(base::Bind(&OfflinePageModelImpl::GetPagesMatchingQuery,
                            weak_ptr_factory_.GetWeakPtr(),
                            base::Passed(builder.Build(GetPolicyController())),
                            multiple_callback));
 }
 
-void OfflinePageModelImpl::GetPagesByOnlineURL(
-    const GURL& online_url,
+void OfflinePageModelImpl::GetPagesByURL(
+    const GURL& url,
+    bool search_by_final_url_only,
     const MultipleOfflinePageItemCallback& callback) {
   RunWhenLoaded(
-      base::Bind(&OfflinePageModelImpl::GetPagesByOnlineURLWhenLoadDone,
-                 weak_ptr_factory_.GetWeakPtr(), online_url, callback));
+      base::Bind(&OfflinePageModelImpl::GetPagesByURLWhenLoadDone,
+                 weak_ptr_factory_.GetWeakPtr(), url,
+                 search_by_final_url_only, callback));
 }
 
-void OfflinePageModelImpl::GetPagesByOnlineURLWhenLoadDone(
-    const GURL& online_url,
+void OfflinePageModelImpl::GetPagesByURLWhenLoadDone(
+    const GURL& url,
+    bool search_by_final_url_only,
     const MultipleOfflinePageItemCallback& callback) const {
   std::vector<OfflinePageItem> result;
 
   GURL::Replacements remove_params;
   remove_params.ClearRef();
 
-  GURL online_url_without_fragment =
-        online_url.ReplaceComponents(remove_params);
+  GURL url_without_fragment = url.ReplaceComponents(remove_params);
 
   for (const auto& id_page_pair : offline_pages_) {
     if (id_page_pair.second.IsExpired())
       continue;
-    if (online_url == id_page_pair.second.url) {
+    if (url == id_page_pair.second.url ||

[fgorski, 2016/11/16 23:43:46]

this does exact matching, whereas outside of this we were dropping fragment. Can
you make sure that it WAI?

[jianli, 2016/11/17 01:12:14]

With more thought, changed to also search against original url with fragment
stripped.

+        (!search_by_final_url_only && url ==
+         id_page_pair.second.original_url)) {
       result.push_back(id_page_pair.second);
       continue;
     }
     // If the full URL does not match, try with the fragment identifier
     // stripped.
-    if (online_url_without_fragment ==
+    if (url_without_fragment ==
         id_page_pair.second.url.ReplaceComponents(remove_params)) {
       result.push_back(id_page_pair.second);
     }
   }
 
   callback.Run(result);
 }
 
 void OfflinePageModelImpl::CheckMetadataConsistency() {
   DCHECK(is_loaded_);
@@ skipping 220 matching lines @@
 }
 
 void OfflinePageModelImpl::DeleteExistingPagesWithSameURL(
     const OfflinePageItem& offline_page) {
   // Remove existing pages generated by the same policy and with same url.
   size_t pages_allowed =
       policy_controller_->GetPolicy(offline_page.client_id.name_space)
           .pages_allowed_per_url;
   if (pages_allowed == kUnlimitedPages)
     return;
-  GetPagesByOnlineURL(
+  GetPagesByURL(
       offline_page.url,
+      true /* search_by_final_url_only */,
       base::Bind(&OfflinePageModelImpl::OnPagesFoundWithSameURL,
                  weak_ptr_factory_.GetWeakPtr(), offline_page, pages_allowed));
 }
 
 void OfflinePageModelImpl::OnPagesFoundWithSameURL(
     const OfflinePageItem& offline_page,
     size_t pages_allowed,
     const MultipleOfflinePageItemResult& items) {
   std::vector<OfflinePageItem> pages_to_delete;
   for (const auto& item : items) {
@@ skipping 197 matching lines @@
   }
 
   base::ThreadTaskRunnerHandle::Get()->PostTask(FROM_HERE, task);
 }
 
 base::Time OfflinePageModelImpl::GetCurrentTime() const {
   return testing_clock_ ? testing_clock_->Now() : base::Time::Now();
 }
 
 }  // namespace offline_pages