Issue 2503853003: Rename CompilationError.location to CompilationError.span

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2503853003: Rename CompilationError.location to CompilationError.span (Closed)

Created:
4 years, 1 month ago by Paul Berry

Modified:
4 years, 1 month ago

Reviewers:
scheglov, Brian Wilkerson

CC:
reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

Rename CompilationError.location to CompilationError.span This should avoid some confusion since its type is SourceSpan, not SourceLocation. R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/da70cf3be2c9f90a4b5ef880c98089cff1c7c938

Created: 4 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	pkg/front_end/lib/compilation_error.dart	View		1 chunk	+2 lines, -2 lines	0 comments	Download

Total messages: 6 (2 generated)

Paul Berry

Committed patchset #1 (id:1) manually as da70cf3be2c9f90a4b5ef880c98089cff1c7c938 (presubmit successful).

4 years, 1 month ago (2016-11-15 18:36:55 UTC) #5

Message was sent while issue was closed.

lgtm