Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Side by Side Diff: BUILD.gn

Issue 2503833003: Restore accidentally deleted comment (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//third_party/icu/config.gni") 5 import("//third_party/icu/config.gni")
6 6
7 if (is_android) { 7 if (is_android) {
8 import("//build/config/android/rules.gni") 8 import("//build/config/android/rules.gni")
9 } 9 }
10 10
(...skipping 55 matching lines...) Expand 10 before | Expand all | Expand 10 after
66 # Will cut down the code size. 66 # Will cut down the code size.
67 "U_CHARSET_IS_UTF8=1", 67 "U_CHARSET_IS_UTF8=1",
68 ] 68 ]
69 69
70 if (is_win) { 70 if (is_win) {
71 # Disable some compiler warnings. 71 # Disable some compiler warnings.
72 cflags += [ 72 cflags += [
73 "/wd4005", # Macro redefinition. 73 "/wd4005", # Macro redefinition.
74 "/wd4068", # Unknown pragmas. 74 "/wd4068", # Unknown pragmas.
75 "/wd4267", # Conversion from size_t on 64-bits. 75 "/wd4267", # Conversion from size_t on 64-bits.
76 # http://bugs.icu-project.org/trac/ticket/12821
76 "/wd4333", # Right shift by too large amount. 77 "/wd4333", # Right shift by too large amount.
77 ] 78 ]
78 } else if (is_linux || is_android) { 79 } else if (is_linux || is_android) {
79 cflags += [ 80 cflags += [
80 "-Wno-unused-function", 81 "-Wno-unused-function",
81 ] 82 ]
82 } 83 }
83 if (is_clang) { 84 if (is_clang) {
84 cflags += [ 85 cflags += [
85 # ICU uses its own deprecated functions. 86 # ICU uses its own deprecated functions.
(...skipping 938 matching lines...) Expand 10 before | Expand all | Expand 10 after
1024 } 1025 }
1025 } 1026 }
1026 1027
1027 source_set("icudata") { 1028 source_set("icudata") {
1028 sources = [ "$data_assembly" ] 1029 sources = [ "$data_assembly" ]
1029 defines = [ "U_HIDE_DATA_SYMBOL" ] 1030 defines = [ "U_HIDE_DATA_SYMBOL" ]
1030 deps = [ ":make_data_assembly", ] 1031 deps = [ ":make_data_assembly", ]
1031 } 1032 }
1032 } 1033 }
1033 } 1034 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698