Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 2503833002: MIPS[64]: Use immediates for kMips[64]Tst in code-generator-mips[64].cc (Closed)

Created:
4 years, 1 month ago by ivica.bogosavljevic
Modified:
4 years, 1 month ago
Reviewers:
miran.karic, miran.karic
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

MIPS[64]: Use immediates for kMips[64]Tst in code-generator-mips[64].cc The patch optimizes the generation of code for kMips[64]Tst in code-generator-mips[64].cc. We allow usage of immediate for kMips[64]Tst in VisitWordCompare in order to remove an unnecessary immediate load to register. This fix is motivated by Richards benchark in Octane benchmark suite, since it is used a lot there. BUG= Committed: https://crrev.com/ecd166d5e86cb71db7bfceb0a4109bc7d72e6ff4 Cr-Commit-Position: refs/heads/master@{#40992}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+88 lines, -68 lines) Patch
M src/compiler/mips/instruction-selector-mips.cc View 1 chunk +44 lines, -34 lines 0 comments Download
M src/compiler/mips64/instruction-selector-mips64.cc View 1 chunk +44 lines, -34 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
ivica.bogosavljevic
PTAL
4 years, 1 month ago (2016-11-15 09:11:43 UTC) #2
miran.karic
On 2016/11/15 09:11:43, ivica.bogosavljevic wrote: > PTAL LGTM, I only think it would be good ...
4 years, 1 month ago (2016-11-15 10:02:50 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2503833002/1
4 years, 1 month ago (2016-11-15 13:44:43 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-15 13:46:44 UTC) #12
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:34:05 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ecd166d5e86cb71db7bfceb0a4109bc7d72e6ff4
Cr-Commit-Position: refs/heads/master@{#40992}

Powered by Google App Engine
This is Rietveld 408576698