Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Issue 250383008: Refactor the interface for the CrxDownloader to take a callback. (Closed)

Created:
6 years, 8 months ago by Sorin Jianu
Modified:
6 years, 8 months ago
Reviewers:
waffles
CC:
chromium-reviews, cpu_(ooo_6.6-7.5), Shrikant Kelkar
Visibility:
Public.

Description

Refactor the interface for the CrxDownloader to take a callback. To be consistent with the rest of the artifacts in the component updater, the non-blocking calls for the CrxDownloader take a callback to be called when the non-blocking call completes. This change allows adding further callbacks besides the completion callback, such as a callback to be called when download progress is made. This change is a pure refactoring and it should be a NOP in terms of existing functionality. BUG=366388 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266304

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -55 lines) Patch
M chrome/browser/component_updater/background_downloader_win.h View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/component_updater/background_downloader_win.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/component_updater/component_updater_service.cc View 1 chunk +7 lines, -8 lines 0 comments Download
M chrome/browser/component_updater/crx_downloader.h View 1 chunk +6 lines, -6 lines 0 comments Download
M chrome/browser/component_updater/crx_downloader.cc View 4 chunks +15 lines, -17 lines 0 comments Download
M chrome/browser/component_updater/test/crx_downloader_unittest.cc View 12 chunks +18 lines, -14 lines 1 comment Download
M chrome/browser/component_updater/url_fetcher_downloader.h View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/component_updater/url_fetcher_downloader.cc View 1 chunk +2 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
waffles
lgtm https://codereview.chromium.org/250383008/diff/1/chrome/browser/component_updater/test/crx_downloader_unittest.cc File chrome/browser/component_updater/test/crx_downloader_unittest.cc (left): https://codereview.chromium.org/250383008/diff/1/chrome/browser/component_updater/test/crx_downloader_unittest.cc#oldcode323 chrome/browser/component_updater/test/crx_downloader_unittest.cc:323: I'm glad you got rid of this. Now ...
6 years, 8 months ago (2014-04-24 23:27:53 UTC) #1
Sorin Jianu
The CQ bit was checked by sorin@chromium.org
6 years, 8 months ago (2014-04-25 17:03:07 UTC) #2
Sorin Jianu
The CQ bit was unchecked by sorin@chromium.org
6 years, 8 months ago (2014-04-25 21:10:01 UTC) #3
Sorin Jianu
The CQ bit was checked by sorin@chromium.org
6 years, 8 months ago (2014-04-25 21:10:09 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sorin@chromium.org/250383008/1
6 years, 8 months ago (2014-04-25 22:01:51 UTC) #5
commit-bot: I haz the power
6 years, 8 months ago (2014-04-26 00:38:58 UTC) #6
Message was sent while issue was closed.
Change committed as 266304

Powered by Google App Engine
This is Rietveld 408576698