Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2278)

Unified Diff: content/renderer/service_worker/service_worker_context_client.cc

Issue 2503813002: Fix and refactor downloaded file handling in the loading stack (Closed)
Patch Set: move to dtor Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/common/url_loader.mojom ('k') | third_party/WebKit/LayoutTests/TestExpectations » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/service_worker/service_worker_context_client.cc
diff --git a/content/renderer/service_worker/service_worker_context_client.cc b/content/renderer/service_worker/service_worker_context_client.cc
index c19944bfc590320dbf0f0dcfe90e93af6fd21f6e..6575e18bc79357a535e33cfc2e46ebb08bc7abf9 100644
--- a/content/renderer/service_worker/service_worker_context_client.cc
+++ b/content/renderer/service_worker/service_worker_context_client.cc
@@ -261,8 +261,11 @@ class ServiceWorkerContextClient::NavigationPreloadRequest final
"respondWith or waitUntil.")));
}
- void OnReceiveResponse(const ResourceResponseHead& response_head) override {
+ void OnReceiveResponse(
+ const ResourceResponseHead& response_head,
+ mojom::DownloadedTempFilePtr downloaded_file) override {
DCHECK(!response_);
+ DCHECK(!downloaded_file);
response_ = base::MakeUnique<blink::WebServiceWorkerResponse>();
response_->setURL(url_);
DCHECK(response_head.headers);
« no previous file with comments | « content/common/url_loader.mojom ('k') | third_party/WebKit/LayoutTests/TestExpectations » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698