Fix and refactor downloaded file handling in the loading stack

content/browser/loader/downloaded_temp_file_impl.h

+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CONTENT_BROWSER_LOADER_DOWNLOADED_TEMP_FILE_IMPL_H_
+#define CONTENT_BROWSER_LOADER_DOWNLOADED_TEMP_FILE_IMPL_H_
+
+#include "base/files/file_path.h"
+#include "base/macros.h"
+#include "base/memory/ref_counted.h"
+#include "content/common/content_export.h"
+#include "content/common/url_loader_factory.mojom.h"
+#include "mojo/public/cpp/bindings/binding.h"
+
+namespace storage {
+class ShareableFileReference;
+}
+
+namespace content {
+
+class ResourceDispatcherHostImpl;
+
+class CONTENT_EXPORT DownloadedTempFileImpl final

[mmenke, 2016/11/15 15:59:05]

Docs?

[tzik, 2016/11/16 09:14:56]

Done.

+    : public mojom::DownloadedTempFile {
+ public:
+  DownloadedTempFileImpl(ResourceDispatcherHostImpl* rdh,
+                         int child_id,
+                         int request_id,
+                         const base::FilePath& path);
+  ~DownloadedTempFileImpl() override;
+
+  // mojo::DownloadedTempFile implementation.
+  void Release() override;
+
+  mojo::InterfacePtr<mojom::DownloadedTempFile> CreateInterfacePtrAndBind();
+
+  int child_id() const { return child_id_; }
+  int request_id() const { return request_id_; }
+  const base::FilePath& path() const { return path_; }

[yhirano, 2016/11/15 13:15:26]

Not used

[tzik, 2016/11/16 09:14:56]

Done.

+  const scoped_refptr<storage::ShareableFileReference>& reference() const {
+    return reference_;
+  }
+
+ private:
+  mojo::Binding<DownloadedTempFile> binding_;
+
+  ResourceDispatcherHostImpl* rdh_;
+  int child_id_;
+  int request_id_;
+  base::FilePath path_;

[yhirano, 2016/11/15 13:15:26]

ditto

[tzik, 2016/11/16 09:14:56]

Done.

+
+  scoped_refptr<storage::ShareableFileReference> reference_;
+
+  DISALLOW_COPY_AND_ASSIGN(DownloadedTempFileImpl);
+};
+
+}  // namespace content
+
+#endif  // CONTENT_BROWSER_LOADER_DOWNLOADED_TEMP_FILE_IMPL_H_