fix #27784 and fix #27785, fromEnvironment constants in DDC

pkg/dev_compiler/lib/src/analyzer/context.dart

Index: pkg/dev_compiler/lib/src/analyzer/context.dart
diff --git a/pkg/dev_compiler/lib/src/analyzer/context.dart b/pkg/dev_compiler/lib/src/analyzer/context.dart
index 209c2fe386ee0b1f97d908a5e52548781c70c094..5a39dde305a329c51276ee767f10d386482c561f 100644
--- a/pkg/dev_compiler/lib/src/analyzer/context.dart
+++ b/pkg/dev_compiler/lib/src/analyzer/context.dart
@@ -46,16 +46,21 @@ class AnalyzerOptions {
   /// of the unsummarized one.
   final String dartSdkSummaryPath;
 
+  /// Defined variables used by `bool.fromEnvironment` etc.
+  final Map<String, String> declaredVariables;
+
   AnalyzerOptions(
       {this.summaryPaths: const [],
       String dartSdkPath,
       this.dartSdkSummaryPath,
       this.customUrlMappings: const {},
       this.packageRoot: null,
-      this.packagePaths: const []})
+      this.packagePaths: const [],
+      this.declaredVariables: const {}})
       : dartSdkPath = dartSdkPath ?? getSdkDir().path;
 
-  factory AnalyzerOptions.fromArguments(ArgResults args) {
+  factory AnalyzerOptions.fromArguments(
+      ArgResults args, Map<String, String> declaredVariables) {
     var sdkPath = args['dart-sdk'] ?? getSdkDir().path;
     var sdkSummaryPath = args['dart-sdk-summary'];
 
@@ -72,7 +77,8 @@ class AnalyzerOptions {
         dartSdkSummaryPath: sdkSummaryPath,
         customUrlMappings: _parseUrlMappings(args['url-mapping']),
         packageRoot: args['package-root'],
-        packagePaths: (args['package-paths'] as String)?.split(',') ?? []);
+        packagePaths: (args['package-paths'] as String)?.split(',') ?? [],
+        declaredVariables: declaredVariables);
   }
 
   /// Whether to resolve 'package:' uris using the multi-package resolver.
@@ -186,3 +192,25 @@ DartUriResolver createSdkPathResolver(String sdkSummaryPath, String sdkPath) {
       : _createFolderBasedDartSdk(sdkPath);
   return new DartUriResolver(sdk);
 }
+
+List<String> parseDeclaredVariables(
+    List<String> args, Map<String, String> declaredVars) {
+  int count = args.length;
+  var remainingArgs = <String>[];
+  for (int i = 0; i < count; i++) {
+    String arg = args[i];

[vsm, 2016/11/16 19:16:22]

nit: could be var

[Jennifer Messerly, 2016/11/16 20:11:48]

Done.

+    if (arg == '--') {
+      while (i < count) {
+        remainingArgs.add(args[i++]);
+      }
+    } else if (arg.startsWith("-D")) {
+      // The format for defined variables is:
+      //     -D<name>=<value>
+      List<String> parts = arg.substring(2).split('=');

[vsm, 2016/11/16 19:16:22]

ditto

[Jennifer Messerly, 2016/11/16 20:11:48]

Done.

+      declaredVars[parts[0]] = parts.length > 1 ? parts[1] : '';
+    } else {
+      remainingArgs.add(arg);
+    }
+  }
+  return remainingArgs;
+}