fix #27784 and fix #27785, fromEnvironment constants in DDC

fix #27784 and fix #27785, fromEnvironment constants in DDC

R=vsm@google.com

Committed: https://github.com/dart-lang/sdk/commit/365d9a000a786a2803385bfac08ff82ec5cfd316

[Jennifer Messerly, 2016-11-16 01:31:28]

Description was changed from

==========
fix #27784, fromEnvironment constants should now work
==========

to

==========
fix #27784 and fix #27785, fromEnvironment constants in DDC
==========

[Jennifer Messerly, 2016-11-16 18:57:47]

jmesserly@google.com changed reviewers:
+ vsm@google.com

[vsm, 2016-11-16 19:16:22]

lgtm with small comment - nice!

https://codereview.chromium.org/2503803004/diff/40001/pkg/dev_compiler/lib/sr...
File pkg/dev_compiler/lib/src/analyzer/context.dart (right):

https://codereview.chromium.org/2503803004/diff/40001/pkg/dev_compiler/lib/sr...
pkg/dev_compiler/lib/src/analyzer/context.dart:201: String arg = args[i];
nit: could be var

https://codereview.chromium.org/2503803004/diff/40001/pkg/dev_compiler/lib/sr...
pkg/dev_compiler/lib/src/analyzer/context.dart:209: List<String> parts =
arg.substring(2).split('=');
ditto

https://codereview.chromium.org/2503803004/diff/40001/pkg/dev_compiler/lib/sr...
File pkg/dev_compiler/lib/src/compiler/code_generator.dart (right):

https://codereview.chromium.org/2503803004/diff/40001/pkg/dev_compiler/lib/sr...
pkg/dev_compiler/lib/src/compiler/code_generator.dart:3974: ? js.boolean(false)
Can you add a comment explaining this case?  When would we have value.isUnknown
and why is it falsy?  Should it be a static error?

[Jennifer Messerly, 2016-11-16 20:11:48]

Thanks!!!

https://codereview.chromium.org/2503803004/diff/40001/pkg/dev_compiler/lib/sr...
File pkg/dev_compiler/lib/src/analyzer/context.dart (right):

https://codereview.chromium.org/2503803004/diff/40001/pkg/dev_compiler/lib/sr...
pkg/dev_compiler/lib/src/analyzer/context.dart:201: String arg = args[i];
On 2016/11/16 19:16:22, vsm wrote:
> nit: could be var

Done.

https://codereview.chromium.org/2503803004/diff/40001/pkg/dev_compiler/lib/sr...
pkg/dev_compiler/lib/src/analyzer/context.dart:209: List<String> parts =
arg.substring(2).split('=');
On 2016/11/16 19:16:22, vsm wrote:
> ditto

Done.

https://codereview.chromium.org/2503803004/diff/40001/pkg/dev_compiler/lib/sr...
File pkg/dev_compiler/lib/src/compiler/code_generator.dart (right):

https://codereview.chromium.org/2503803004/diff/40001/pkg/dev_compiler/lib/sr...
pkg/dev_compiler/lib/src/compiler/code_generator.dart:3974: ? js.boolean(false)
On 2016/11/16 19:16:22, vsm wrote:
> Can you add a comment explaining this case?  When would we have
value.isUnknown
> and why is it falsy?  Should it be a static error?

Sure, as best as I can. Unfortunately behavior of -D options is more or less
undocumented. :(

but it seems to follow from:
https://api.dartlang.org/stable/1.20.1/dart-core/bool/bool.fromEnvironment.html

[Jennifer Messerly, 2016-11-16 20:20:30]

Description was changed from

==========
fix #27784 and fix #27785, fromEnvironment constants in DDC
==========

to

==========
fix #27784 and fix #27785, fromEnvironment constants in DDC

R=vsm@google.com

Committed:
https://github.com/dart-lang/sdk/commit/365d9a000a786a2803385bfac08ff82ec5cfd316
==========

[Jennifer Messerly, 2016-11-16 20:20:31]

Committed patchset #5 (id:80001) manually as
365d9a000a786a2803385bfac08ff82ec5cfd316 (presubmit successful).