Issue 2503803003: Revert "Connect analyzer's AnalysisError object to front_end's CompilationError."

Issue 2503803003: Revert "Connect analyzer's AnalysisError object to front_end's CompilationError." (Closed)

Created:
4 years, 1 month ago by Paul Berry

Modified:
4 years, 1 month ago

Reviewers:
scheglov, Brian Wilkerson

CC:
reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

Revert "Connect analyzer's AnalysisError object to front_end's CompilationError." This reverts commit fc5270df72d47daf68e16b8985591d40f3ee264a. TBR=scheglov@google.com, brianwilkerson@google.com Committed: https://github.com/dart-lang/sdk/commit/0c928771fc8ec6586f9a8fcd9fb7f535da018006

Created: 4 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+2 lines, -100 lines)			Patch
M	pkg/analyzer/lib/error/error.dart	View	3 chunks	+1 line, -6 lines	0 comments	Download
M	pkg/analyzer/lib/src/generated/source.dart	View	3 chunks	+0 lines, -7 lines	0 comments	Download
M	pkg/analyzer/lib/src/generated/source_io.dart	View	3 chunks	+0 lines, -7 lines	0 comments	Download
M	pkg/analyzer/lib/src/source/source_resource.dart	View	3 chunks	+0 lines, -7 lines	0 comments	Download
M	pkg/analyzer/lib/src/string_source.dart	View	3 chunks	+0 lines, -7 lines	0 comments	Download
M	pkg/analyzer/lib/src/summary/package_bundle_reader.dart	View	2 chunks	+0 lines, -5 lines	0 comments	Download
M	pkg/analyzer/lib/src/task/html.dart	View	1 chunk	+0 lines, -3 lines	0 comments	Download
D	pkg/analyzer/test/generated/error_test.dart	View	1 chunk	+0 lines, -44 lines	0 comments	Download
M	pkg/analyzer/test/generated/test_support.dart	View	3 chunks	+0 lines, -7 lines	0 comments	Download
M	pkg/front_end/lib/compilation_error.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/front_end/lib/src/base/source.dart	View	2 chunks	+0 lines, -6 lines	0 comments	Download

Total messages: 4 (1 generated)

Paul Berry

Committed patchset #1 (id:1) manually as 0c928771fc8ec6586f9a8fcd9fb7f535da018006 (presubmit successful).

4 years, 1 month ago (2016-11-15 18:00:40 UTC) #2

Paul Berry

4 years, 1 month ago (2016-11-15 20:13:56 UTC) #4

Message was sent while issue was closed.

On 2016/11/15 20:12:44, Brian Wilkerson wrote:
> lgtm, but why?

Because of your comments here: https://codereview.chromium.org/2498133002/