Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(476)

Issue 2503763004: Fix comment preservation in java_cpp_enum.py. (Closed)

Created:
4 years, 1 month ago by estevenson
Modified:
4 years, 1 month ago
Reviewers:
agrieve, xunjieli
CC:
chromium-reviews, mikecase+watch_chromium.org, jbudorick+watch_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix comment preservation in java_cpp_enum.py. Currently, comments aren't preserved when prefix stripping is used. This CL modifies java_cpp_enum.py to preserve comments whether or not prefix stripping occurs. BUG=665642 Committed: https://crrev.com/50fea5f2ba37fc191a580b18a223c457047cda71 Cr-Commit-Position: refs/heads/master@{#432504}

Patch Set 1 #

Patch Set 2 : Create separate test for comment preservation w/prefix-stripping #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -15 lines) Patch
M build/android/gyp/java_cpp_enum.py View 2 chunks +16 lines, -12 lines 0 comments Download
M build/android/gyp/java_cpp_enum_tests.py View 1 2 chunks +36 lines, -3 lines 0 comments Download

Messages

Total messages: 17 (11 generated)
estevenson
ptal!
4 years, 1 month ago (2016-11-16 00:51:11 UTC) #4
agrieve
On 2016/11/16 00:51:11, estevenson wrote: > ptal! lgtm
4 years, 1 month ago (2016-11-16 14:57:50 UTC) #9
xunjieli
lgtm
4 years, 1 month ago (2016-11-16 15:01:20 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2503763004/20001
4 years, 1 month ago (2016-11-16 15:54:51 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-16 16:01:08 UTC) #15
commit-bot: I haz the power
4 years, 1 month ago (2016-11-16 16:05:43 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/50fea5f2ba37fc191a580b18a223c457047cda71
Cr-Commit-Position: refs/heads/master@{#432504}

Powered by Google App Engine
This is Rietveld 408576698