Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Issue 2503763002: Revert of Add skia extension to allow setting default fontmgr on linux. Use it to allow the linux blimp clien… (Closed)

Created:
4 years, 1 month ago by horo
Modified:
4 years, 1 month ago
CC:
chromium-reviews, anandc+watch-blimp_chromium.org, maniscalco+watch-blimp_chromium.org, sriramsr+watch-blimp_chromium.org, bgoldman+watch-blimp_chromium.org, steimel+watch-blimp_chromium.org, gcasto+watch-blimp_chromium.org, shaktisahu+watch-blimp_chromium.org, nyquist+watch-blimp_chromium.org, perumaal+watch-blimp_chromium.org, marcinjb+watch-blimp_chromium.org, kmarshall+watch-blimp_chromium.org, lethalantidote+watch-blimp_chromium.org, dtrainor+watch-blimp_chromium.org, scf+watch-blimp_chromium.org, khushalsagar+watch-blimp_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Add skia extension to allow setting default fontmgr on linux. Use it to allow the linux blimp clien… (patchset #4 id:60001 of https://codereview.chromium.org/2500643002/ ) Reason for revert: Caused failures at "sizes" check on Linux x64 bot. https://uberchromegw.corp.google.com/i/chromium/builders/Linux%20x64 See crbug.com/665274 BUG=665274 Original issue's description: > Add skia extension to allow setting default fontmgr on linux. Use it to allow the linux blimp client to use android fonts > > BUG=617821 > > Committed: https://crrev.com/f6c1cd2bb6a2253e9547c091671c98ed28300685 > Cr-Commit-Position: refs/heads/master@{#432023} TBR=bungeman@chromium.org,khushalsagar@chromium.org,bungeman@google.com,steimel@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=617821 Committed: https://crrev.com/cbf14bb02366acf3cb250c98c10208e8f955ad53 Cr-Commit-Position: refs/heads/master@{#432082}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -95 lines) Patch
M blimp/client/app/linux/blimp_main.cc View 3 chunks +0 lines, -49 lines 0 comments Download
M blimp/client/core/switches/blimp_client_switches.h View 1 chunk +0 lines, -3 lines 0 comments Download
M blimp/client/core/switches/blimp_client_switches.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M skia/BUILD.gn View 3 chunks +2 lines, -1 line 0 comments Download
D skia/ext/fontmgr_default_linux.h View 1 chunk +0 lines, -15 lines 0 comments Download
D skia/ext/fontmgr_default_linux.cc View 1 chunk +0 lines, -25 lines 0 comments Download

Messages

Total messages: 4 (3 generated)
horo
4 years, 1 month ago (2016-11-15 03:46:02 UTC) #2
Created Revert of Add skia extension to allow setting default fontmgr on linux.
Use it to allow the linux blimp clien…

Powered by Google App Engine
This is Rietveld 408576698