Issue 250373002: Enable builds of some translate libraries in GN world.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 250373002: Enable builds of some translate libraries in GN world. (Closed)

Created:
6 years, 8 months ago by tfarina

Modified:
6 years, 7 months ago

Reviewers:
brettw

CC:
chromium-reviews, Dirk Pranke

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Enable builds of some translate libraries in GN world. Debug: $ gn gen out/Debug_gn --args=is_debug=true $ ninja -C out/Debug_gn translate_core_browser translate_core_common Release: $ gn gen out/Release_gn --args=is_debug=false $ ninja -C out/Release_gn translate_core_browser translate_core_common BUG=None TEST=see above, it LINKS. R=brettw@chromium.org TBR=droger Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266540

Patch Set 1 #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -2 lines)			Patch
	M	BUILD.gn	View		1 chunk	+2 lines, -2 lines	0 comments	Download
	M	components/translate/BUILD.gn	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

tfarina

6 years, 7 months ago (2014-04-28 13:32:54 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r266540 (presubmit successful).

Expand Messages | Collapse Messages