Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2503713002:
[Mac] Fix for omnibox lock icon (Closed)
Description[Mac] Fix for omnibox lock icon
- Align the permission bubble to be below the Lock Icon
- Fix blurry lock icon
BUG=662411, 662365
Committed: https://crrev.com/f1b792a63088465603c079e7dc1037acb2b67427
Cr-Commit-Position: refs/heads/master@{#433283}
Patch Set 1 #Patch Set 2 : fixed test #
Messages
Total messages: 31 (20 generated)
spqchan@chromium.org changed reviewers: + shrike@chromium.org
PTAL
The CQ bit was checked by spqchan@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
The CQ bit was checked by spqchan@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
The CQ bit was checked by spqchan@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
The CQ bit was checked by spqchan@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
On 2016/11/15 00:19:40, spqchan wrote: > PTAL ping
lgtm (at least the dialog positioning - I don't see the blurry lock on my Retina machine)
On 2016/11/17 17:41:10, shrike wrote: > lgtm (at least the dialog positioning - I don't see the blurry lock on my Retina > machine) awesome, thanks! Turns out you don't need Retina to see it. In order to see it, turn off the security chip and compare the lock icons between https://amazon.com and https://apple.com
spqchan@chromium.org changed reviewers: + avi@chromium.org
+avi for ownership
On 2016/11/17 18:00:45, spqchan wrote: > +avi for ownership ping :)
lgtm
On 2016/11/18 19:08:55, Avi wrote: > lgtm thanks!
The CQ bit was checked by spqchan@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== [Mac] Fix for omnibox lock icon - Align the permission bubble to be below the Lock Icon - Fix blurry lock icon BUG=662411, 662365 ========== to ========== [Mac] Fix for omnibox lock icon - Align the permission bubble to be below the Lock Icon - Fix blurry lock icon BUG=662411, 662365 Committed: https://crrev.com/f1b792a63088465603c079e7dc1037acb2b67427 Cr-Commit-Position: refs/heads/master@{#433283} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/f1b792a63088465603c079e7dc1037acb2b67427 Cr-Commit-Position: refs/heads/master@{#433283} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
