Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(625)

Issue 25037002: remove Isolate::Current from ScriptData and Script (Closed)

Created:
7 years, 2 months ago by dcarney
Modified:
7 years, 2 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Visibility:
Public.

Description

remove Isolate::Current from ScriptData and Script R=mstarzinger@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=17041

Patch Set 1 #

Patch Set 2 : test fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -28 lines) Patch
M include/v8.h View 1 chunk +3 lines, -1 line 0 comments Download
M src/api.cc View 1 10 chunks +29 lines, -14 lines 0 comments Download
M test/cctest/test-api.cc View 7 chunks +14 lines, -8 lines 0 comments Download
M test/cctest/test-parsing.cc View 4 chunks +6 lines, -5 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
dcarney
7 years, 2 months ago (2013-09-27 12:39:08 UTC) #1
Michael Starzinger
LGTM.
7 years, 2 months ago (2013-10-01 08:38:39 UTC) #2
dcarney
7 years, 2 months ago (2013-10-01 09:56:13 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r17041 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698