Making the SHA1 entropy provider use the randomization_seed.

Making the SHA1 entropy provider use the randomization_seed.

BUG=665603
Committed: https://crrev.com/c6e07e224e5d6cc495f8c6d86ae2741abede6b06
Cr-Commit-Position: refs/heads/master@{#433561}

[jwd, 2016-11-15 23:13:40]

jwd@chromium.org changed reviewers:
+ rkaplow@chromium.org

[rkaplow, 2016-11-16 06:31:01]

lgtm

Can you update
https://codesearch.chromium.org/chromium/src/components/variations/entropy_pr...

[Alexei Svitkine (slow), 2016-11-16 06:36:48]

asvitkine@chromium.org changed reviewers:
+ asvitkine@chromium.org

[Alexei Svitkine (slow), 2016-11-16 06:36:48]

lgtm % comment

https://codereview.chromium.org/2503683005/diff/1/components/variations/entro...
File components/variations/entropy_provider.cc (right):

https://codereview.chromium.org/2503683005/diff/1/components/variations/entro...
components/variations/entropy_provider.cc:94: std::string input(entropy_source_
+ randomization_string);
Nit: How about avoiding the extra string copy?

e.g.

std::string input(entropy_source_);
input.append(randomization_seed == 0 ? trial_name :
base::UintToString(randomization_seed));

This way, you don't need an extra temp randomization_string copy.

[jwd, 2016-11-16 16:15:38]

On 2016/11/16 06:31:01, rkaplow wrote:
> lgtm
> 
> Can you update
>
https://codesearch.chromium.org/chromium/src/components/variations/entropy_pr...

Done, updated the comment for permuted provider to mention randomization source
too.

[jwd, 2016-11-16 16:15:45]

https://codereview.chromium.org/2503683005/diff/1/components/variations/entro...
File components/variations/entropy_provider.cc (right):

https://codereview.chromium.org/2503683005/diff/1/components/variations/entro...
components/variations/entropy_provider.cc:94: std::string input(entropy_source_
+ randomization_string);
On 2016/11/16 06:36:48, Alexei Svitkine (very slow) wrote:
> Nit: How about avoiding the extra string copy?
> 
> e.g.
> 
> std::string input(entropy_source_);
> input.append(randomization_seed == 0 ? trial_name :
> base::UintToString(randomization_seed));
> 
> This way, you don't need an extra temp randomization_string copy.
>   

Done.

[jwd, 2016-11-21 15:35:59]

The CQ bit was checked by jwd@chromium.org

[jwd, 2016-11-21 15:35:59]

The patchset sent to the CQ was uploaded after l-g-t-m from
rkaplow@chromium.org, asvitkine@chromium.org
Link to the patchset: https://codereview.chromium.org/2503683005/#ps40001
(title: "Updating comments")

[commit-bot: I haz the power, 2016-11-21 15:36:28]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-21 16:36:57]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1479742559495880,
"parent_rev": "3dd4072b0037852c8b7150b42bbe44cb4a1c8d09", "commit_rev":
"bd3f93ec6a726b1a2b3ecfbf77c65982e8c0acfb"}

[commit-bot: I haz the power, 2016-11-21 16:37:21]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-11-21 16:40:09]

Description was changed from

==========
Making the SHA1 entropy provider use the randomization_seed.

BUG=665603
==========

to

==========
Making the SHA1 entropy provider use the randomization_seed.

BUG=665603

Committed: https://crrev.com/c6e07e224e5d6cc495f8c6d86ae2741abede6b06
Cr-Commit-Position: refs/heads/master@{#433561}
==========

[commit-bot: I haz the power, 2016-11-21 16:40:10]

Patchset 3 (id:??) landed as
https://crrev.com/c6e07e224e5d6cc495f8c6d86ae2741abede6b06
Cr-Commit-Position: refs/heads/master@{#433561}