Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Issue 2503683004: Organize TestExpectations for smooth scroll flakiness. (Closed)

Created:
4 years, 1 month ago by skobes
Modified:
4 years, 1 month ago
Reviewers:
bokan
CC:
chromium-reviews, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Organize TestExpectations for smooth scroll flakiness. BUG=665577 Committed: https://crrev.com/03039b7b951dd4d7f48dc6f1eef0786e9d1c4196 Cr-Commit-Position: refs/heads/master@{#432348}

Patch Set 1 #

Total comments: 2

Patch Set 2 : address review comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -16 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 4 chunks +12 lines, -16 lines 0 comments Download

Messages

Total messages: 18 (10 generated)
skobes
4 years, 1 month ago (2016-11-15 21:47:35 UTC) #4
bokan
lgtm https://codereview.chromium.org/2503683004/diff/1/third_party/WebKit/LayoutTests/TestExpectations File third_party/WebKit/LayoutTests/TestExpectations (right): https://codereview.chromium.org/2503683004/diff/1/third_party/WebKit/LayoutTests/TestExpectations#newcode915 third_party/WebKit/LayoutTests/TestExpectations:915: crbug.com/665577 virtual/threaded/fast/scroll-behavior/smooth-scroll/track-scroll.html [ Pass Failure ] This was ...
4 years, 1 month ago (2016-11-15 22:08:26 UTC) #5
skobes
https://codereview.chromium.org/2503683004/diff/1/third_party/WebKit/LayoutTests/TestExpectations File third_party/WebKit/LayoutTests/TestExpectations (right): https://codereview.chromium.org/2503683004/diff/1/third_party/WebKit/LayoutTests/TestExpectations#newcode915 third_party/WebKit/LayoutTests/TestExpectations:915: crbug.com/665577 virtual/threaded/fast/scroll-behavior/smooth-scroll/track-scroll.html [ Pass Failure ] On 2016/11/15 22:08:26, ...
4 years, 1 month ago (2016-11-15 22:28:27 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2503683004/20001
4 years, 1 month ago (2016-11-15 22:29:06 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linux/builds/261219)
4 years, 1 month ago (2016-11-15 22:57:59 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2503683004/20001
4 years, 1 month ago (2016-11-16 01:24:51 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-16 01:40:03 UTC) #16
commit-bot: I haz the power
4 years, 1 month ago (2016-11-16 01:48:38 UTC) #18
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/03039b7b951dd4d7f48dc6f1eef0786e9d1c4196
Cr-Commit-Position: refs/heads/master@{#432348}

Powered by Google App Engine
This is Rietveld 408576698