|
|
Chromium Code Reviews
DescriptionOrganize TestExpectations for smooth scroll flakiness.
BUG=665577
Committed: https://crrev.com/03039b7b951dd4d7f48dc6f1eef0786e9d1c4196
Cr-Commit-Position: refs/heads/master@{#432348}
Patch Set 1 #
Total comments: 2
Patch Set 2 : address review comment #Messages
Total messages: 18 (10 generated)
The CQ bit was checked by skobes@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
skobes@chromium.org changed reviewers: + bokan@chromium.org
lgtm https://codereview.chromium.org/2503683004/diff/1/third_party/WebKit/LayoutTe... File third_party/WebKit/LayoutTests/TestExpectations (right): https://codereview.chromium.org/2503683004/diff/1/third_party/WebKit/LayoutTe... third_party/WebKit/LayoutTests/TestExpectations:915: crbug.com/665577 virtual/threaded/fast/scroll-behavior/smooth-scroll/track-scroll.html [ Pass Failure ] This was previously only for Linux and Win7, was the change intentional?
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
https://codereview.chromium.org/2503683004/diff/1/third_party/WebKit/LayoutTe... File third_party/WebKit/LayoutTests/TestExpectations (right): https://codereview.chromium.org/2503683004/diff/1/third_party/WebKit/LayoutTe... third_party/WebKit/LayoutTests/TestExpectations:915: crbug.com/665577 virtual/threaded/fast/scroll-behavior/smooth-scroll/track-scroll.html [ Pass Failure ] On 2016/11/15 22:08:26, bokan wrote: > This was previously only for Linux and Win7, was the change intentional? Done.
The CQ bit was checked by skobes@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from bokan@chromium.org Link to the patchset: https://codereview.chromium.org/2503683004/#ps20001 (title: "address review comment")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
The CQ bit was checked by skobes@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Organize TestExpectations for smooth scroll flakiness. BUG=665577 ========== to ========== Organize TestExpectations for smooth scroll flakiness. BUG=665577 Committed: https://crrev.com/03039b7b951dd4d7f48dc6f1eef0786e9d1c4196 Cr-Commit-Position: refs/heads/master@{#432348} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/03039b7b951dd4d7f48dc6f1eef0786e9d1c4196 Cr-Commit-Position: refs/heads/master@{#432348} |
