Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(593)

Issue 2503663002: Printing: Add command line switch to rendering text with GDI. (Closed)

Created:
4 years, 1 month ago by Lei Zhang
Modified:
4 years, 1 month ago
Reviewers:
scottmg
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Printing: Add command line switch to rendering text with GDI. Add --enable-gdi-text-printing for those who want to experiment with it. Rendering text with GDI is still disabled by default and --disable-gdi-text-printing overrules the enable flag. BUG=409472, 658606 Committed: https://crrev.com/653aaed16ec270dcb3c4da44a5adabb501228bc3 Cr-Commit-Position: refs/heads/master@{#432052}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Sort #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -5 lines) Patch
M chrome/browser/printing/print_view_manager_base.cc View 1 chunk +7 lines, -3 lines 0 comments Download
M chrome/common/chrome_switches.h View 1 2 chunks +5 lines, -1 line 0 comments Download
M chrome/common/chrome_switches.cc View 1 3 chunks +13 lines, -1 line 0 comments Download

Messages

Total messages: 12 (6 generated)
Lei Zhang
We haven't given up on this yet, so adding back the code from r429177 as ...
4 years, 1 month ago (2016-11-14 23:15:06 UTC) #4
scottmg
lgtm https://codereview.chromium.org/2503663002/diff/1/chrome/common/chrome_switches.h File chrome/common/chrome_switches.h (right): https://codereview.chromium.org/2503663002/diff/1/chrome/common/chrome_switches.h#newcode357 chrome/common/chrome_switches.h:357: extern const char kEnableGDITextPrinting[]; These were sorted-ish before.
4 years, 1 month ago (2016-11-14 23:29:03 UTC) #5
Lei Zhang
https://codereview.chromium.org/2503663002/diff/1/chrome/common/chrome_switches.h File chrome/common/chrome_switches.h (right): https://codereview.chromium.org/2503663002/diff/1/chrome/common/chrome_switches.h#newcode357 chrome/common/chrome_switches.h:357: extern const char kEnableGDITextPrinting[]; On 2016/11/14 23:29:03, scottmg wrote: ...
4 years, 1 month ago (2016-11-14 23:36:43 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2503663002/20001
4 years, 1 month ago (2016-11-14 23:37:22 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-15 01:51:18 UTC) #10
commit-bot: I haz the power
4 years, 1 month ago (2016-11-15 01:56:53 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/653aaed16ec270dcb3c4da44a5adabb501228bc3
Cr-Commit-Position: refs/heads/master@{#432052}

Powered by Google App Engine
This is Rietveld 408576698