JumpToFrame refactor

JumpToFrame refactor

- Refactor the JumpToExceptionHandle code so that it is now built from
  two pieces: JumpToFrame and RunExceptionHandler.

- Refactor the Simulator::Longjmp() code so that it is no longer
  exception-specific.  Instead it uses the RunExceptionHandler stub.

This makes it so that the JumpToFrame stub and Simulator::JumpToFrame
have the same semantics.  This will make it easier to land the Rewind
changes I am working on.

There are some oddities for dbc.

BUG=
R=johnmccutchan@google.com

Committed: https://github.com/dart-lang/sdk/commit/5ed13d3298e44cea5de0558bbb30efabf7a9f8e8

[turnidge, 2016-11-14 22:09:44]

turnidge@google.com changed reviewers:
+ johnmccutchan@google.com

[Cutch, 2016-11-14 22:19:14]

LGTM with a comment about a comment.

https://codereview.chromium.org/2503653002/diff/20001/runtime/vm/stub_code_ar...
File runtime/vm/stub_code_arm.cc (right):

https://codereview.chromium.org/2503653002/diff/20001/runtime/vm/stub_code_ar...
runtime/vm/stub_code_arm.cc:1877: __ bx(LR);  // Jump to program counter.
// Jump to link register.

[turnidge, 2016-11-14 22:38:24]

Description was changed from

==========
JumpToFrame refactor

- Refactor the JumpToExceptionHandle code so that it is now built from
  two pieces: JumpToFrame and RunExceptionHandler.

- Refactor the Simulator::Longjmp() code so that it is no longer
  exception-specific.  Instead it uses the RunExceptionHandler stub.

This makes it so that the JumpToFrame stub and Simulator::JumpToFrame
have the same semantics.  This will make it easier to land the Rewind
changes I am working on.

There are some oddities for dbc.

BUG=
==========

to

==========
JumpToFrame refactor

- Refactor the JumpToExceptionHandle code so that it is now built from
  two pieces: JumpToFrame and RunExceptionHandler.

- Refactor the Simulator::Longjmp() code so that it is no longer
  exception-specific.  Instead it uses the RunExceptionHandler stub.

This makes it so that the JumpToFrame stub and Simulator::JumpToFrame
have the same semantics.  This will make it easier to land the Rewind
changes I am working on.

There are some oddities for dbc.

BUG=
R=johnmccutchan@google.com

Committed:
https://github.com/dart-lang/sdk/commit/5ed13d3298e44cea5de0558bbb30efabf7a9f8e8
==========

[turnidge, 2016-11-14 22:38:25]

Committed patchset #3 (id:40001) manually as
5ed13d3298e44cea5de0558bbb30efabf7a9f8e8 (presubmit successful).

[turnidge, 2016-11-14 22:39:01]

https://codereview.chromium.org/2503653002/diff/20001/runtime/vm/stub_code_ar...
File runtime/vm/stub_code_arm.cc (right):

https://codereview.chromium.org/2503653002/diff/20001/runtime/vm/stub_code_ar...
runtime/vm/stub_code_arm.cc:1877: __ bx(LR);  // Jump to program counter.
On 2016/11/14 22:19:14, Cutch wrote:
> // Jump to link register.

Done.