Fixed collected cookies view info bar visibility

chrome/browser/ui/views/collected_cookies_views.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/collected_cookies_views.h"
 
 #include "base/macros.h"
 #include "chrome/browser/browsing_data/browsing_data_appcache_helper.h"
 #include "chrome/browser/browsing_data/browsing_data_channel_id_helper.h"
 #include "chrome/browser/browsing_data/browsing_data_cookie_helper.h"
@@ skipping 132 matching lines @@
                              kInfobarHorizontalPadding,
                              kInfobarVerticalPadding,
                              views::kRelatedControlSmallHorizontalSpacing));
     content_->AddChildView(info_image_);
     content_->AddChildView(label_);
     UpdateVisibility(false, CONTENT_SETTING_BLOCK, base::string16());
   }
 
   // views::View overrides.
   gfx::Size GetPreferredSize() const override {
-    if (!visible())
-      return gfx::Size();
+    // Always return the preferred size, even if not currently visible. This
+    // ensures that the layout manager always reserves space within the view
+    // so it can be made visible when necessary. Otherwise, changing the
+    // visibility of this view would require the entire dialog to be resized,
+    // which is undesirable from both a UX and technical perspective.
 
     // Add space around the banner.
     gfx::Size size(content_->GetPreferredSize());
     size.Enlarge(0, 2 * views::kRelatedControlVerticalSpacing);
     return size;
   }
 
   void Layout() override {
     content_->SetBounds(
         0, views::kRelatedControlVerticalSpacing,
@@ skipping 396 matching lines @@
 ///////////////////////////////////////////////////////////////////////////////
 // CollectedCookiesViews, content::NotificationObserver implementation:
 
 void CollectedCookiesViews::Observe(
     int type,
     const content::NotificationSource& source,
     const content::NotificationDetails& details) {
   DCHECK_EQ(chrome::NOTIFICATION_COLLECTED_COOKIES_SHOWN, type);
   GetWidget()->Close();
 }