Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(442)

Issue 2503633003: arc: enable use_new_wrapper_types for app.mojom (Closed)

Created:
4 years, 1 month ago by Yusuke Sato
Modified:
4 years, 1 month ago
CC:
chromium-reviews, elijahtaylor+arcwatch_chromium.org, sadrul, yusukes+watch_chromium.org, tfarina, hidehiko+watch_chromium.org, lhchavez+watch_chromium.org, kalyank, Matt Giuca
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

arc: enable use_new_wrapper_types for app.mojom BUG=662510 BUG=624136 TEST=try Committed: https://crrev.com/0b2ebb8d84d1038290e5bef4fd73f1fb61458bb5 Cr-Commit-Position: refs/heads/master@{#432605}

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : rebase again #

Unified diffs Side-by-side diffs Delta from patch set Stats (+112 lines, -109 lines) Patch
M chrome/browser/ui/app_list/arc/arc_app_list_prefs.h View 3 chunks +16 lines, -15 lines 0 comments Download
M chrome/browser/ui/app_list/arc/arc_app_list_prefs.cc View 11 chunks +29 lines, -33 lines 0 comments Download
M chrome/browser/ui/app_list/arc/arc_app_unittest.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/ash/launcher/arc_app_launcher_browsertest.cc View 1 chunk +15 lines, -14 lines 0 comments Download
M components/arc/BUILD.gn View 1 2 2 chunks +1 line, -1 line 0 comments Download
M components/arc/test/fake_app_instance.h View 4 chunks +17 lines, -17 lines 0 comments Download
M components/arc/test/fake_app_instance.cc View 6 chunks +30 lines, -25 lines 0 comments Download

Messages

Total messages: 28 (18 generated)
Yusuke Sato
Owners, PTAL. Luis: everything Xiyuan: chrome/browser/ui/app_list/arc/ Stefan: chrome/browser/ui/ash/launcher/ Yury: FYI
4 years, 1 month ago (2016-11-15 21:26:34 UTC) #7
Mr4D (OOO till 08-26)
c/b/u/a/launcher lgtm
4 years, 1 month ago (2016-11-16 03:05:02 UTC) #8
Luis Héctor Chávez
lgtm
4 years, 1 month ago (2016-11-16 03:09:44 UTC) #9
Yusuke Sato
Rebased, no code change. Xiyuan, please take a look at c/b/ui/app_list/arc/.
4 years, 1 month ago (2016-11-16 18:56:42 UTC) #16
xiyuan
lgtm Sorry, missed this.
4 years, 1 month ago (2016-11-16 19:01:23 UTC) #17
Yusuke Sato
thanks!
4 years, 1 month ago (2016-11-16 19:02:47 UTC) #18
khmel
lgtm
4 years, 1 month ago (2016-11-16 19:08:59 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2503633003/40001
4 years, 1 month ago (2016-11-16 19:43:48 UTC) #24
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 1 month ago (2016-11-16 20:04:17 UTC) #26
commit-bot: I haz the power
4 years, 1 month ago (2016-11-16 20:24:39 UTC) #28
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/0b2ebb8d84d1038290e5bef4fd73f1fb61458bb5
Cr-Commit-Position: refs/heads/master@{#432605}

Powered by Google App Engine
This is Rietveld 408576698