Propagate browser zoom changes to embedded PDFs.

chrome/browser/resources/pdf/pdf.js

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 'use strict';
 
 /**
  * @return {number} Width of a scrollbar in pixels
  */
 function getScrollbarWidth() {
@@ skipping 119 matching lines @@
   // Create the viewport.
   var shortWindow = window.innerHeight < PDFViewer.TOOLBAR_WINDOW_MIN_HEIGHT;
   var topToolbarHeight =
       (toolbarEnabled) ? PDFViewer.MATERIAL_TOOLBAR_HEIGHT : 0;
   this.viewport_ = new Viewport(window,
                                 this.sizer_,
                                 this.viewportChanged_.bind(this),
                                 this.beforeZoom_.bind(this),
                                 this.afterZoom_.bind(this),
                                 getScrollbarWidth(),
-                                this.browserApi_.getDefaultZoom(),
+                                this.browserApi_.getInitialZoom(),

[raymes, 2016/11/17 00:59:57]

Hmm, how come you're changing this to InitialZoom rather than DefaultZoom?
+sammc who fixed some bugs around this.

[Sam McNally, 2016/11/18 04:59:23]

The reason for the default zoom was for PDFs we want to zoom the PDF to fit the
page, but not zoom in more than the default zoom level. As the comment for
lookupInitialZoom() says, this isn't always the same as the zoom level of the
tab.

This should still be the default zoom for top-level PDFs, and either the default
zoom or default zoom * initial zoom for embedded PDFs.

[Kevin McNee, 2016/11/22 23:17:32]

Right. If the tab the pdf is in has been zoomed, we want the pdf to start off
zoomed as well.

[Sam McNally, 2016/11/28 07:25:13]

For non-embedded PDFs we still want to use the default zoom here.

[Kevin McNee, 2016/11/28 16:18:44]

Yes, if it's not embedded, we set the zoom mode to manual, which resets the zoom
level to the default. So the initial zoom is equal to the default zoom. But for
clarity, I can change it back.

[Kevin McNee, 2016/11/28 17:03:32]

Done.

                                 topToolbarHeight);
 
   // Create the plugin object dynamically so we can set its src. The plugin
   // element is sized to fill the entire window and is set to be fixed
   // positioning, acting as a viewport. The plugin renders into this viewport
   // according to the scroll position of the window.
   this.plugin_ = document.createElement('embed');
   // NOTE: The plugin's 'id' field must be set to 'plugin' since
   // chrome/renderer/printing/print_web_view_helper.cc actually references it.
   this.plugin_.id = 'plugin';
@@ skipping 72 matching lines @@
     var disposition =
         e.detail.newtab ? Navigator.WindowOpenDisposition.NEW_BACKGROUND_TAB :
                           Navigator.WindowOpenDisposition.CURRENT_TAB;
     this.navigator_.navigate(e.detail.uri, disposition);
   }.bind(this));
 
   this.toolbarManager_ =
       new ToolbarManager(window, this.toolbar_, this.zoomToolbar_);
 
   // Set up the ZoomManager.
-  this.zoomManager_ = new ZoomManager(
+  this.zoomManager_ = ZoomManager.create(this.browserApi_.getZoomBehaviour(),
       this.viewport_, this.browserApi_.setZoom.bind(this.browserApi_),
       this.browserApi_.getInitialZoom());
   this.browserApi_.addZoomEventListener(
       this.zoomManager_.onBrowserZoomChange.bind(this.zoomManager_));
 
   // Setup the keyboard event listener.
   document.addEventListener('keydown', this.handleKeyEvent_.bind(this));
   document.addEventListener('mousemove', this.handleMouseEvent_.bind(this));
   document.addEventListener('mouseout', this.handleMouseEvent_.bind(this));
 
@@ skipping 674 matching lines @@
    * Each bookmark is an Object containing a:
    * - title
    * - page (optional)
    * - array of children (themselves bookmarks)
    * @type {Array} the top-level bookmarks of the PDF.
    */
   get bookmarks() {
     return this.bookmarks_;
   }
 };