media/cast/rtp_receiver/rtp_parser/test/rtp_packet_builder.h - Issue 250363002: [Cast] Clean-up RtpCastHeader and RtpParser, removing the last WebRTC dependency.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/cast/rtp_receiver/rtp_parser/test/rtp_packet_builder.h

Issue 250363002: [Cast] Clean-up RtpCastHeader and RtpParser, removing the last WebRTC dependency. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Addressed hubbe's comment. Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « media/cast/rtp_receiver/rtp_parser/rtp_parser_unittest.cc ('k') | media/cast/rtp_receiver/rtp_parser/test/rtp_packet_builder.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: media/cast/rtp_receiver/rtp_parser/test/rtp_packet_builder.h

diff --git a/media/cast/rtp_receiver/rtp_parser/test/rtp_packet_builder.h b/media/cast/rtp_receiver/rtp_parser/test/rtp_packet_builder.h

index ac1425200ad0d7efdcfece4a782a45abea37c051..7337798e3119c005bb1780d1b341bf72bb0ca9d5 100644

--- a/media/cast/rtp_receiver/rtp_parser/test/rtp_packet_builder.h

+++ b/media/cast/rtp_receiver/rtp_parser/test/rtp_packet_builder.h

@@ -12,14 +12,15 @@

namespace media {

namespace cast {

+// TODO(miu): Consolidate with RtpPacketizer as a single Cast packet

+// serialization implementation.

class RtpPacketBuilder {

public:

RtpPacketBuilder();

void SetKeyFrame(bool is_key);

- void SetFrameId(uint32 frame_id);

+ void SetFrameIds(uint32 frame_id, uint32 reference_frame_id);

void SetPacketId(uint16 packet_id);

void SetMaxPacketId(uint16 max_packet_id);

- void SetReferenceFrameId(uint32 reference_frame_id, bool is_set);

void SetTimestamp(uint32 timestamp);

void SetSequenceNumber(uint16 sequence_number);

void SetMarkerBit(bool marker);

@@ -33,7 +34,6 @@ class RtpPacketBuilder {

uint16 packet_id_;

uint16 max_packet_id_;

uint32 reference_frame_id_;

- bool is_reference_set_;

uint32 timestamp_;

uint16 sequence_number_;

bool marker_;