Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(387)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2503623003: Revert "JumpToFrame refactor" (Closed)

Created:
4 years, 1 month ago by turnidge
Modified:
4 years, 1 month ago
Reviewers:
Cutch
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert "JumpToFrame refactor" This reverts commit 5ed13d3298e44cea5de0558bbb30efabf7a9f8e8. BUG= Committed: https://github.com/dart-lang/sdk/commit/1cdb3d215593844599b78c55729228dede63e651

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+147 lines, -235 lines) Patch
M runtime/vm/exceptions.h View 1 chunk +0 lines, -5 lines 0 comments Download
M runtime/vm/exceptions.cc View 3 chunks +12 lines, -17 lines 0 comments Download
M runtime/vm/profiler.cc View 1 chunk +5 lines, -4 lines 0 comments Download
M runtime/vm/simulator_arm.h View 1 chunk +6 lines, -1 line 0 comments Download
M runtime/vm/simulator_arm.cc View 2 chunks +10 lines, -1 line 0 comments Download
M runtime/vm/simulator_arm64.h View 1 chunk +6 lines, -1 line 0 comments Download
M runtime/vm/simulator_arm64.cc View 2 chunks +10 lines, -1 line 0 comments Download
M runtime/vm/simulator_dbc.h View 1 chunk +6 lines, -1 line 0 comments Download
M runtime/vm/simulator_dbc.cc View 2 chunks +10 lines, -15 lines 0 comments Download
M runtime/vm/simulator_mips.h View 1 chunk +6 lines, -1 line 0 comments Download
M runtime/vm/simulator_mips.cc View 2 chunks +10 lines, -1 line 0 comments Download
M runtime/vm/stub_code.h View 3 chunks +3 lines, -5 lines 0 comments Download
M runtime/vm/stub_code.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M runtime/vm/stub_code_arm.cc View 2 chunks +8 lines, -25 lines 0 comments Download
M runtime/vm/stub_code_arm64.cc View 2 chunks +8 lines, -25 lines 0 comments Download
M runtime/vm/stub_code_dbc.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M runtime/vm/stub_code_ia32.cc View 2 chunks +10 lines, -27 lines 0 comments Download
M runtime/vm/stub_code_mips.cc View 2 chunks +11 lines, -28 lines 0 comments Download
M runtime/vm/stub_code_x64.cc View 2 chunks +21 lines, -29 lines 0 comments Download
M runtime/vm/thread.h View 2 chunks +0 lines, -21 lines 0 comments Download
M runtime/vm/thread.cc View 3 chunks +0 lines, -16 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
turnidge
4 years, 1 month ago (2016-11-14 23:56:20 UTC) #2
turnidge
Committed patchset #1 (id:1) manually as 1cdb3d215593844599b78c55729228dede63e651 (presubmit successful).
4 years, 1 month ago (2016-11-14 23:57:08 UTC) #4
turnidge
TBR=cutch
4 years, 1 month ago (2016-11-14 23:59:06 UTC) #5
Cutch
4 years, 1 month ago (2016-11-15 00:01:51 UTC) #6
Message was sent while issue was closed. 
lgtm

Powered by Google App Engine
This is Rietveld 408576698