Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(470)

Unified Diff: ash/common/wm/container_finder.cc

Issue 2503623002: Support creation of toplevel mus::Windows on separate displays (Closed)
Patch Set: Fix container root lookup. Don't need to initialize container id for unit test. Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | ash/mus/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ash/common/wm/container_finder.cc
diff --git a/ash/common/wm/container_finder.cc b/ash/common/wm/container_finder.cc
index 60785c75c48e6905f1864cd6f62024c417d1d9e5..f9ce52ead559d402bbb14335f2ca67f89a5959c1 100644
--- a/ash/common/wm/container_finder.cc
+++ b/ash/common/wm/container_finder.cc
@@ -76,7 +76,9 @@ WmWindow* GetDefaultParent(WmWindow* context,
// Transient window should use the same root as its transient parent.
target_root = transient_parent->GetRootWindow();
} else {
- target_root = FindContainerRoot(context->GetShell(), bounds);
+ target_root = context->GetRootWindow();
mfomitchev 2016/11/15 20:29:34 This makes sense to me, but the original way seems
thanhph 2016/11/15 21:09:55 If the bounds is correct, then this function FindC
+ if (!target_root)
+ target_root = FindContainerRoot(context->GetShell(), bounds);
}
switch (window->GetType()) {
« no previous file with comments | « no previous file | ash/mus/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698