Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(493)

Unified Diff: ash/mus/test/wm_test_base.cc

Issue 2503623002: Support creation of toplevel mus::Windows on separate displays (Closed)
Patch Set: Rebase and change constant kInvalidDisplayId namespace. Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ash/mus/test/wm_test_base.cc
diff --git a/ash/mus/test/wm_test_base.cc b/ash/mus/test/wm_test_base.cc
index c45eb6e73457fd27f8e573754940c7f90f90f533..8822401b86c47bfc4be61cebd9917f4f8c4c9914 100644
--- a/ash/mus/test/wm_test_base.cc
+++ b/ash/mus/test/wm_test_base.cc
@@ -14,7 +14,6 @@
#include "ash/mus/window_manager_application.h"
#include "services/ui/public/cpp/property_type_converters.h"
#include "services/ui/public/cpp/window_tree_client.h"
-#include "ui/display/display.h"
namespace ash {
namespace mus {
@@ -123,11 +122,17 @@ ui::Window* WmTestBase::CreateTestWindow(const gfx::Rect& bounds,
return window;
}
-ui::Window* WmTestBase::CreateFullscreenTestWindow() {
+ui::Window* WmTestBase::CreateFullscreenTestWindow(int64_t display_id) {
mfomitchev 2016/11/23 17:57:59 Use full signature (with default value) here.
thanhph 2016/11/23 18:42:19 Done. I can't put default values in both .cc and .
mfomitchev 2016/11/23 19:05:15 Oh, okay, sorry - didn't realize this. Please keep
std::map<std::string, std::vector<uint8_t>> properties;
properties[ui::mojom::WindowManager::kShowState_Property] =
mojo::ConvertTo<std::vector<uint8_t>>(
static_cast<int32_t>(ui::mojom::ShowState::FULLSCREEN));
+
+ if (display_id != display::kInvalidDisplayId) {
+ properties[ui::mojom::WindowManager::kInitialDisplayId_Property] =
+ mojo::ConvertTo<std::vector<uint8_t>>(display_id);
+ }
+
ui::Window* window = test_helper_->GetRootsOrderedByDisplayId()[0]
->window_manager()
->NewTopLevelWindow(&properties);

Powered by Google App Engine
This is Rietveld 408576698