Support creation of toplevel mus::Windows on separate displays

ash/mus/root_window_controller.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ash/mus/root_window_controller.h"
 
 #include <stdint.h>
 
 #include <algorithm>
 #include <map>
@@ skipping 84 matching lines @@
 
   // TODO(sky): constrain and validate properties before passing to server.
   ui::Window* window = root_->window_tree()->NewWindow(properties);
   window->SetBounds(CalculateDefaultBounds(window));
 
   ui::Window* container_window = nullptr;
   int container_id = kShellWindowId_Invalid;
   if (GetRequestedContainer(window, &container_id)) {
     container_window = GetWindowByShellWindowId(container_id)->mus_window();
   } else {
-    // TODO(sky): window->bounds() isn't quite right.
+    const gfx::Point& screen_point_top_right =

[mfomitchev, 2016/11/18 17:36:24]

Nit: Any particular reason you are using const references here? const makes some
sense, but I am not sure the reference does..

[thanhph, 2016/11/18 19:15:44]

Done.

+        wm_root_window_controller_->ConvertPointToScreen(
+            WmWindowMus::Get(window), window->bounds().top_right());
+
+    const gfx::Point& screen_point_bottom_left =
+        wm_root_window_controller_->ConvertPointToScreen(
+            WmWindowMus::Get(window), window->bounds().bottom_left());
+
+    const gfx::Rect& screen_bound =

[mfomitchev, 2016/11/18 17:36:24]

The variable name is a little confusing - sounds like the bounds of the screen.
Maybe call the variable "bounds_in_screen"? Then for consistency we can rename
the other two "top_right_in_screen", "bottom_left_in_screen".

[thanhph, 2016/11/18 19:15:44]

Done. Thanks!

+        gfx::Rect(screen_point_bottom_left.x(), screen_point_top_right.y(),
+                  screen_point_top_right.x() - screen_point_bottom_left.x(),
+                  screen_point_bottom_left.y() - screen_point_top_right.y());
+
     container_window = WmWindowMus::GetMusWindow(wm::GetDefaultParent(
-        WmWindowMus::Get(root_), WmWindowMus::Get(window), window->bounds()));
+        WmWindowMus::Get(root_), WmWindowMus::Get(window), screen_bound));
   }
   DCHECK(WmWindowMus::Get(container_window)->IsContainer());
 
   if (provide_non_client_frame) {
     NonClientFrameController::Create(container_window, window,
                                      window_manager_->window_manager_client());
   } else {
     container_window->AddChild(window);
   }
-
   window_count_++;
-
   return window;
 }
 
 WmWindowMus* RootWindowController::GetWindowByShellWindowId(int id) {
   return WmWindowMus::AsWmWindowMus(
       WmWindowMus::Get(root_)->GetChildByShellWindowId(id));
 }
 
 void RootWindowController::SetWorkAreaInests(const gfx::Insets& insets) {
   gfx::Rect old_work_area = display_.work_area();
@@ skipping 47 matching lines @@
 void RootWindowController::CreateLayoutManagers() {
   // Override the default layout managers for certain containers.
   WmWindowMus* lock_screen_container =
       GetWindowByShellWindowId(kShellWindowId_LockScreenContainer);
   layout_managers_[lock_screen_container->mus_window()].reset(
       new ScreenlockLayout(lock_screen_container->mus_window()));
 }
 
 }  // namespace mus
 }  // namespace ash