Support creation of toplevel mus::Windows on separate displays

ash/mus/bridge/wm_root_window_controller_mus.h

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef ASH_MUS_BRIDGE_WM_ROOT_WINDOW_CONTROLLER_MUS_H_
 #define ASH_MUS_BRIDGE_WM_ROOT_WINDOW_CONTROLLER_MUS_H_
 
 #include "ash/common/wm_root_window_controller.h"
 #include "base/macros.h"
 
@@ skipping 22 matching lines @@
   static WmRootWindowControllerMus* Get(ui::Window* window) {
     return const_cast<WmRootWindowControllerMus*>(
         Get(const_cast<const ui::Window*>(window)));
   }
   static const WmRootWindowControllerMus* Get(const ui::Window* window);
 
   RootWindowController* root_window_controller() {
     return root_window_controller_;
   }
 
+  gfx::Rect* ConvertWindowToScreen(const WmWindowMus* source,

[mfomitchev, 2016/11/17 17:14:01]

Doesn't seem like there's any reason to create a method for this here. Can we
just do the calculations in NewTopLevelWindow? Also, perhaps it would be more
convenient to use WmWindow::ConvertPointToScreen rather than
WmRootWindowControllerMus?

Also, we are leaking the rect - it is created on the heap and never deleted.
Just use an object, not an object pointer.

[thanhph, 2016/11/17 19:08:30]

Putting this function here could be good for future reuse. I'll move it back to
root_window_controller.cc since there's no other use of it now. I tried this
WmWindow::ConvertPointToScreen the whole day yesterday but didn't work. The
problem was somehow WmWindow wasn't initialized and as a result, I kept getting
ASAN:DEADLYSIGNAL. 
Thanks. I'll try this now.

+                                   const ui::Window* window) const;
+
   // Screen conversion functions.
   gfx::Point ConvertPointToScreen(const WmWindowMus* source,
                                   const gfx::Point& point) const;
   gfx::Point ConvertPointFromScreen(const WmWindowMus* target,
                                     const gfx::Point& point) const;
 
   const display::Display& GetDisplay() const;
 
   // Exposed as public so WindowManager can call it.
   void MoveWindowsTo(WmWindow* dest);
@@ skipping 19 matching lines @@
   WmShellMus* shell_;
   RootWindowController* root_window_controller_;
 
   DISALLOW_COPY_AND_ASSIGN(WmRootWindowControllerMus);
 };
 
 }  // namespace mus
 }  // namespace ash
 
 #endif  // ASH_MUS_BRIDGE_WM_ROOT_WINDOW_CONTROLLER_MUS_H_