Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1508)

Issue 2503583002: Hide advanced commands from cipd client help. (Closed)

Created:
4 years, 1 month ago by iannucci
Modified:
4 years, 1 month ago
Reviewers:
dnj, Vadim Sh.
CC:
chromium-reviews, infra-reviews+luci-go_chromium.org, andrew.wang, todd, tandrii+luci-go_chromium.org, M-A Ruel
Target Ref:
refs/heads/master
Project:
luci-go
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 10

Patch Set 2 : address comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -33 lines) Patch
M cipd/client/cmd/cipd/friendly.go View 1 3 chunks +3 lines, -0 lines 0 comments Download
M cipd/client/cmd/cipd/main.go View 1 12 chunks +14 lines, -3 lines 0 comments Download
M client/authcli/authcli.go View 5 chunks +12 lines, -7 lines 0 comments Download
M client/cmd/isolate/main.go View 1 chunk +3 lines, -3 lines 0 comments Download
M client/cmd/isolated/main.go View 1 chunk +3 lines, -3 lines 0 comments Download
M client/cmd/swarming/main.go View 1 chunk +3 lines, -3 lines 0 comments Download
M deploytool/cmd/luci_deploy/main.go View 1 chunk +3 lines, -3 lines 0 comments Download
M grpc/cmd/rpc/main.go View 1 chunk +2 lines, -2 lines 0 comments Download
M logdog/client/cli/main.go View 1 chunk +3 lines, -3 lines 0 comments Download
M logdog/client/cmd/logdog_butler/main.go View 1 chunk +3 lines, -3 lines 0 comments Download
M logdog/common/storage/archive/logdog_archive_test/main.go View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
iannucci
4 years, 1 month ago (2016-11-14 19:36:22 UTC) #1
iannucci
This one is pretty easy, PTAL
4 years, 1 month ago (2016-11-14 20:02:23 UTC) #2
Vadim Sh.
https://codereview.chromium.org/2503583002/diff/1/cipd/client/cmd/cipd/main.go File cipd/client/cmd/cipd/main.go (right): https://codereview.chromium.org/2503583002/diff/1/cipd/client/cmd/cipd/main.go#newcode943 cipd/client/cmd/cipd/main.go:943: Advanced: true, hmm... I think it's important to give ...
4 years, 1 month ago (2016-11-14 20:13:27 UTC) #3
iannucci
https://codereview.chromium.org/2503583002/diff/1/cipd/client/cmd/cipd/main.go File cipd/client/cmd/cipd/main.go (right): https://codereview.chromium.org/2503583002/diff/1/cipd/client/cmd/cipd/main.go#newcode943 cipd/client/cmd/cipd/main.go:943: Advanced: true, On 2016/11/14 20:13:27, Vadim Sh. wrote: > ...
4 years, 1 month ago (2016-11-14 20:32:32 UTC) #4
Vadim Sh.
lgtm
4 years, 1 month ago (2016-11-14 21:28:03 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2503583002/20001
4 years, 1 month ago (2016-11-14 21:34:45 UTC) #7
commit-bot: I haz the power
4 years, 1 month ago (2016-11-14 21:41:24 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://github.com/luci/luci-go/commit/a300394a1ae1e7cbcc77b016ec3124a0b5142ccf

Powered by Google App Engine
This is Rietveld 408576698