Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(629)

Unified Diff: content/browser/browser_plugin/browser_plugin_embedder.h

Issue 2503563002: Drag-and-drop: updateDragCursor (Closed)
Patch Set: Addressed comments by nick@. Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/browser_plugin/browser_plugin_embedder.h
diff --git a/content/browser/browser_plugin/browser_plugin_embedder.h b/content/browser/browser_plugin/browser_plugin_embedder.h
index 63f60d859d82c1ab6984989241771efd58e8db74..5e4026c978adb5dfd3ebd01b632033b8e60f8776 100644
--- a/content/browser/browser_plugin/browser_plugin_embedder.h
+++ b/content/browser/browser_plugin/browser_plugin_embedder.h
@@ -38,7 +38,6 @@ class CONTENT_EXPORT BrowserPluginEmbedder : public WebContentsObserver {
void DidSendScreenRects();
// WebContentsObserver implementation.
- bool OnMessageReceived(const IPC::Message& message) override;
bool OnMessageReceived(const IPC::Message& message,
RenderFrameHost* render_frame_host) override;
@@ -67,6 +66,11 @@ class CONTENT_EXPORT BrowserPluginEmbedder : public WebContentsObserver {
// operation, if there's any.
void SystemDragEnded();
+ // The page wants to update the mouse cursor during a drag & drop
+ // operation. This update will be suppressed if the cursor is dragging over a
+ // guest.
+ bool OnUpdateDragCursor();
+
// Used to handle special keyboard events.
bool HandleKeyboardEvent(const NativeWebKeyboardEvent& event);
@@ -117,7 +121,6 @@ class CONTENT_EXPORT BrowserPluginEmbedder : public WebContentsObserver {
void OnAttach(RenderFrameHost* render_frame_host,
int instance_id,
const BrowserPluginHostMsg_Attach_Params& params);
- void OnUpdateDragCursor(bool* handled);
// Used to correctly update the cursor when dragging over a guest, and to
// handle a race condition when dropping onto the guest that started the drag

Powered by Google App Engine
This is Rietveld 408576698