Drag-and-drop: updateDragCursor

content/browser/web_contents/web_contents_impl.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/web_contents/web_contents_impl.h"
 
 #include <stddef.h>
 
 #include <cmath>
 #include <utility>
@@ skipping 647 matching lines @@
 
   return WebContents::FromRenderFrameHost(render_frame_host);
 }
 
 RenderFrameHostManager* WebContentsImpl::GetRenderManagerForTesting() {
   return GetRenderManager();
 }
 
 bool WebContentsImpl::OnMessageReceived(RenderViewHost* render_view_host,
                                         const IPC::Message& message) {
-  return OnMessageReceived(render_view_host, NULL, message);
+  return OnMessageReceived(render_view_host, nullptr, nullptr, message);
 }
 
 bool WebContentsImpl::OnMessageReceived(RenderViewHost* render_view_host,
+                                        RenderWidgetHost* render_widget_host,
                                         RenderFrameHost* render_frame_host,
                                         const IPC::Message& message) {
-  DCHECK(render_view_host || render_frame_host);
+  DCHECK(render_view_host || render_widget_host || render_frame_host);
   if (GetWebUI() &&
       static_cast<WebUIImpl*>(GetWebUI())->OnMessageReceived(message)) {
     return true;
   }
 
   if (render_frame_host) {
     for (auto& observer : observers_) {
       if (observer.OnMessageReceived(message, render_frame_host))
         return true;
     }
   } else {
     for (auto& observer : observers_) {
       if (observer.OnMessageReceived(message))

[ncarter (slow), 2016/11/14 20:23:45]

Do we really want/need to do this for all widget messages?

[paulmeyer, 2016/11/14 22:03:53]

No, I've removed the OnMessageReceived() for widgets now.

         return true;
     }
   }
 
   // Message handlers should be aware of which
   // RenderViewHost/RenderFrameHost sent the message, which is temporarily
   // stored in render_(view|frame)_message_source_.
   if (render_frame_host)
     render_frame_message_source_ = render_frame_host;
   else
     render_view_message_source_ = render_view_host;

[ncarter (slow), 2016/11/14 20:23:45]

Would we need render_widget_message_source_ too (This pattern is awful)?

[paulmeyer, 2016/11/14 22:03:53]

Not anymore, I've removed the OnMessageReceived() for widgets now. (yeah...)

 
   bool handled = true;
   IPC_BEGIN_MESSAGE_MAP(WebContentsImpl, message)
     IPC_MESSAGE_HANDLER(FrameHostMsg_DomOperationResponse,
                         OnDomOperationResponse)
     IPC_MESSAGE_HANDLER(FrameHostMsg_DidChangeThemeColor,
                         OnThemeColorChanged)
     IPC_MESSAGE_HANDLER(FrameHostMsg_DidFinishDocumentLoad,
                         OnDocumentLoadedInFrame)
     IPC_MESSAGE_HANDLER(FrameHostMsg_DidFinishLoad, OnDidFinishLoad)
@@ skipping 1772 matching lines @@
 TextInputManager* WebContentsImpl::GetTextInputManager() {
   if (GetOuterWebContents())
     return GetOuterWebContents()->GetTextInputManager();
 
   if (!text_input_manager_)
     text_input_manager_.reset(new TextInputManager());
 
   return text_input_manager_.get();
 }
 
+bool WebContentsImpl::OnMessageReceived(RenderWidgetHost* render_widget_host,
+                                        const IPC::Message& message) {
+  return OnMessageReceived(nullptr, render_widget_host, nullptr, message);
+}
+
 BrowserAccessibilityManager*
     WebContentsImpl::GetRootBrowserAccessibilityManager() {
   RenderFrameHostImpl* rfh = GetMainFrame();
   return rfh ? rfh->browser_accessibility_manager() : nullptr;
 }
 
 BrowserAccessibilityManager*
     WebContentsImpl::GetOrCreateRootBrowserAccessibilityManager() {
   RenderFrameHostImpl* rfh = GetMainFrame();
   return rfh ? rfh->GetOrCreateBrowserAccessibilityManager() : nullptr;
@@ skipping 1514 matching lines @@
 }
 
 void WebContentsImpl::NotifyNavigationEntryCommitted(
     const LoadCommittedDetails& load_details) {
   for (auto& observer : observers_)
     observer.NavigationEntryCommitted(load_details);
 }
 
 bool WebContentsImpl::OnMessageReceived(RenderFrameHost* render_frame_host,
                                         const IPC::Message& message) {
-  return OnMessageReceived(NULL, render_frame_host, message);
+  return OnMessageReceived(nullptr, nullptr, render_frame_host, message);
 }
 
 void WebContentsImpl::OnAssociatedInterfaceRequest(
     RenderFrameHost* render_frame_host,
     const std::string& interface_name,
     mojo::ScopedInterfaceEndpointHandle handle) {
   auto it = binding_sets_.find(interface_name);
   if (it != binding_sets_.end())
     it->second->OnRequestForFrame(render_frame_host, std::move(handle));
 }
@@ skipping 1178 matching lines @@
   dialog_manager_ = dialog_manager;
 }
 
 void WebContentsImpl::RemoveBindingSet(const std::string& interface_name) {
   auto it = binding_sets_.find(interface_name);
   if (it != binding_sets_.end())
     binding_sets_.erase(it);
 }
 
 }  // namespace content