[chromedriver] Retry alert handling if HandleJavaScriptDialog fails.

chrome/test/chromedriver/chrome/javascript_dialog_manager.cc

Index: chrome/test/chromedriver/chrome/javascript_dialog_manager.cc
diff --git a/chrome/test/chromedriver/chrome/javascript_dialog_manager.cc b/chrome/test/chromedriver/chrome/javascript_dialog_manager.cc
index f95d5179f67a746f68054cf7e8cfd36b7a4b045e..3a8228563e7cb2939dfd94ed9082e329fdb3c869 100644
--- a/chrome/test/chromedriver/chrome/javascript_dialog_manager.cc
+++ b/chrome/test/chromedriver/chrome/javascript_dialog_manager.cc
@@ -37,6 +37,13 @@ Status JavaScriptDialogManager::HandleDialog(bool accept,
   if (text)
     params.SetString("promptText", *text);
   Status status = client_->SendCommand("Page.handleJavaScriptDialog", params);
+  std::string msg = status.message();
+  // Retry handling the alert dialog if
+  // JavaScriptDialogManager::HandleJavaScriptDialog function fails.

[samuong, 2016/11/16 19:06:05]

This comment doesn't add much, I don't think it's necessary

[gmanikpure, 2016/11/16 20:22:40]

ok.I will remove it.

+  if (status.IsError() && (msg.find("Could not handle JavaScript dialog") !=
+       std::string::npos)) {

[samuong, 2016/11/16 19:06:04]

This isn't a very specific error message (it gets sent back for any error that
Chrome's JavaScriptDialogManager::HandleJavaScriptDialog sends back) so there's
not much to be gained from checking this.

[gmanikpure, 2016/11/16 20:22:40]

Oh ok, the response received is :- "[38.955][DEBUG]: DEVTOOLS RESPONSE
Page.handleJavaScriptDialog (id=20) {"code":-32603,"message":"Could not handle
JavaScript dialog"}"

Shall i check the code '-32603' instead ?

[samuong, 2016/11/16 21:04:04]

You can just check "status.IsError()", this should be enough to determine
whether an error occurred or not.

[gmanikpure, 2016/11/16 21:26:45]

Done.Please take a look.

+      status = client_->SendCommand("Page.handleJavaScriptDialog", params);
+    }

[samuong, 2016/11/16 19:06:04]

nit: don't need braces for a single-line if body

[gmanikpure, 2016/11/16 20:22:40]

oops, sorry. I had some logging statements inside the if body for analysis
purpose and forgot to remove those braces.

   if (status.IsError())
     return status;