[chromedriver] Retry alert handling if HandleJavaScriptDialog fails.

chrome/test/chromedriver/chrome/javascript_dialog_manager.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/test/chromedriver/chrome/javascript_dialog_manager.h"
 
 #include "base/values.h"
 #include "chrome/test/chromedriver/chrome/devtools_client.h"
 #include "chrome/test/chromedriver/chrome/status.h"
 
@@ skipping 19 matching lines @@
 Status JavaScriptDialogManager::HandleDialog(bool accept,
                                              const std::string* text) {
   if (!IsDialogOpen())
     return Status(kNoAlertOpen);
 
   base::DictionaryValue params;
   params.SetBoolean("accept", accept);
   if (text)
     params.SetString("promptText", *text);
   Status status = client_->SendCommand("Page.handleJavaScriptDialog", params);
-  if (status.IsError())
-    return status;
+  if (status.IsError()) {

[samuong, 2016/11/16 22:53:34]

sorry, one more thing: can you add a comment here saying:

Retry once to work around
https://bugs.chromium.org/p/chromedriver/issues/detail?id=1500

[gmanikpure, 2016/11/16 23:03:42]

Done.

+    status = client_->SendCommand("Page.handleJavaScriptDialog", params);
+    if (status.IsError())
+      return status;
+  }
 
   // Remove a dialog from the queue. Need to check the queue is not empty here,
   // because it could have been cleared during waiting for the command
   // response.
   if (unhandled_dialog_queue_.size())
     unhandled_dialog_queue_.pop_front();
   return Status(kOk);
 }
 
 Status JavaScriptDialogManager::OnConnected(DevToolsClient* client) {
@@ skipping 11 matching lines @@
       return Status(kUnknownError, "dialog event missing or invalid 'message'");
 
     unhandled_dialog_queue_.push_back(message);
   } else if (method == "Page.javascriptDialogClosed") {
     // Inspector only sends this event when all dialogs have been closed.
     // Clear the unhandled queue in case the user closed a dialog manually.
     unhandled_dialog_queue_.clear();
   }
   return Status(kOk);
 }