chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc - Issue 250353003: Password bubble: refactor ManagePasswordsIconView.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc

Issue 250353003: Password bubble: refactor ManagePasswordsIconView. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Rebase. Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc

diff --git a/chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc b/chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc

index d6d379e86a7e987e39d888758eb4f43160592249..0c3f0e03892b268c66955b69bbdc2f91b23b30aa 100644

--- a/chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc

+++ b/chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc

@@ -88,7 +88,9 @@ void ManagePasswordsBubbleView::ShowBubble(content::WebContents* web_contents,

DCHECK(browser);

DCHECK(browser->window());

DCHECK(browser->fullscreen_controller());

- DCHECK(!IsShowing());

+ if (IsShowing())

+ return;

BrowserView* browser_view = BrowserView::GetBrowserViewForBrowser(browser);

bool is_fullscreen = browser_view->IsFullscreen();